__builtin_memcpy/set_inline from clang usage introduction.#594
Open
devnexen wants to merge 1 commit intomicrosoft:devfrom
Open
__builtin_memcpy/set_inline from clang usage introduction.#594devnexen wants to merge 1 commit intomicrosoft:devfrom
devnexen wants to merge 1 commit intomicrosoft:devfrom
Conversation
devnexen
force-pushed
the
builtin_memcpy_inline
branch
from
1ea4aee to
735b3f8
Compare
no extra calls guaranteed during LLVM IR generation but works only on constants unlike their non inline counterparts.
devnexen
force-pushed
the
builtin_memcpy_inline
branch
from
735b3f8 to
167cc14
Compare
Collaborator
|
Thanks for the contribution! However, I am hesitant about this as it adds complexity and it is unclear if it is worth it. |
Contributor
Author
|
Oh I see, there is benefits but are visible with clang providing those guarantees. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
no extra calls guaranteed during LLVM IR generation but works only on constants
unlike their non inline counterparts.