Clean unit tests#2567
Open
anannya03 wants to merge 11 commits into
Open
Conversation
anannya03
requested review from
a team,
JacksonWeber,
JonathanCrd,
achyuth-ms,
anuchandy,
conniey,
ericshape,
jeremyfrosti,
jongio,
kk-src,
lzchen,
matteing,
mattkohnms,
ramnov,
srnagar,
vladimisms and
xiangyan99
as code owners
anannya03
requested review from
XiaofuHuang,
fanyang-mono,
g2vinay,
jairmyree,
msalaman,
rads-1996,
rajkumar-rangaraj,
weng5e and
xiang17
as code owners
anannya03
requested review from
HaofanLiao,
JialinXin,
ankushbindlish2,
chenkennt,
danield137,
ivarprudnikov,
kszobi,
manvkaur,
meirloichter,
pablocastro,
philon-msft,
prvavill,
rebecca-makar,
sharedferret,
taicchoumsft,
vcolin7,
wchigit and
wolfgang-desalvador
as code owners
srnagar
reviewed
May 19, 2026
Comment on lines
+33
to
+34
| Assert.NotEmpty(Command.Description); | ||
| Assert.NotNull(Command.Description); |
Member
There was a problem hiding this comment.
The order should be flipped here - check for not null first before checking for not empty.
Comment on lines
+27
to
+29
| Assert.NotNull(Command.Description); | ||
| Assert.NotEmpty(Command.Description); | ||
| Assert.True(Command.Description.Length <= 1024, "Description should not exceed 1024 characters"); |
Member
There was a problem hiding this comment.
We are doing the same check for Command.Description in all these tests. Is it possible to move this check to CommandUnitTestsBase?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Several unit tests across the MCP Tools codebase (e.g., UpdateWorkbooksCommandTests, UpdateAlertsCommandTests, etc.) currently assert that tool descriptions or summaries exactly match hard-coded strings. These tests frequently fail when a description is reworded or improved for clarity, even though the tool’s behavior remains correct.
Any test that asserts the exact implementation of the unit under test is just repeating the logic of the unit in another place and doesn't really test anything.
This cleans up the tests and asserts that each description is less than 1024 characters.
GitHub issue number?
#788
Pre-merge Checklist
servers/Azure.Mcp.Server/README.mdand/orservers/Fabric.Mcp.Server/README.mddocumentationREADME.mdchanges running the script./eng/scripts/Process-PackageReadMe.ps1. See Package READMEToolDescriptionEvaluatorand obtained a score of0.4or more and a top 3 ranking for all related test promptsconsolidated-tools.jsonbreaking-changelabelservers/Azure.Mcp.Server/docs/azmcp-commands.md./eng/scripts/Update-AzCommandsMetadata.ps1to update tool metadata inazmcp-commands.md(required for CI)servers/Azure.Mcp.Server/docs/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run mcp - pullrequest - liveto run Live Test Pipeline