Skip to content

Prepare Project v2 migration skill bundle integration - #20158

Draft
Karol Zadora-Przylecki (karolz-ms) wants to merge 1 commit into
mainfrom
dev/karolz/project-v2-skill
Draft

Karol Zadora-Przylecki (karolz-ms) wants to merge 1 commit into
mainfrom
dev/karolz/project-v2-skill

Conversation

@karolz-ms

Copy link
Copy Markdown
Contributor

Description

Prepare the Aspire CLI integration for the approval-first aspire-project-v2-migration skill described in #19818.

Important

This draft is based on #19997 and is not ready to merge. The production embedded skills archive has not been updated. Completing this PR requires an attested release containing microsoft/aspire-skills#65, followed by the bundle refresh and validation of the actual embedded installation.

Dependencies

Changes included

  • Extend the shared test bundle with the migration skill and its reference files.
  • Verify default and explicit-name installation, complete reference-file contents, exclusion of evaluation assets, and supported project/user skill locations.
  • Cover skill selection in interactive and chained agent-init flows.
  • Link the migration skill from the .NET hosting integration README.

The product API changes belong to #20157, and the skill implementation belongs to microsoft/aspire-skills#65. Neither is duplicated here.

Required before merging

  • Land the product prerequisites and canonical skill changes.
  • Publish the canonical skills release through its normal attestation workflow.
  • Run eng\scripts\update-aspire-skills-bundle.ps1 -Version <approved-version> and review the generated archive, metadata, installer/project, and any required hook updates.
  • Verify the artifact with eng\scripts\verify-aspire-skills-bundle.ps1.
  • Validate installation from the actual embedded bundle, not only the injected test fixture.
  • Retarget to main after DotnetProjectResource publishing #19997 merges and complete final integration review.

Validation

The focused AspireSkillsBundleTests, AspireSkillsInstallerTests, and AgentInitCommandTests run passed 131 tests, with no failures or skips.

These checks validate the incoming-bundle installation path. They do not assert that the currently embedded archive already contains the new skill.

Part of #19818; the issue is not complete until the released bundle is integrated.

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 20158

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 20158"

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

Copy link
Copy Markdown
Contributor

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

@github-actions

Copy link
Copy Markdown
Contributor

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

@github-actions

Copy link
Copy Markdown
Contributor

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

@github-actions

This comment has been minimized.

@github-actions

Copy link
Copy Markdown
Contributor

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

@github-actions

Copy link
Copy Markdown
Contributor

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

@github-actions

Copy link
Copy Markdown
Contributor

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

Base automatically changed from dev/karolz/project-v2-publish to main September 16, 2026 22:08
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor

Tests selector

1 / 99 PR test projects · 0 PR jobs, from 2 changed files.

Selected PR test projects (1 / 99)

Aspire.Cli.Tests

Selected PR jobs (0)

none


How these were chosen — grouped by what changed

🧪 tests/Aspire.Cli.Tests/Commands/AgentInitCommandTests.cs (changed test)
1 directly: Aspire.Cli.Tests

🧪 tests/Aspire.Cli.Tests/TestServices/FakePlaywrightServices.cs (changed test)
1 directly: Aspire.Cli.Tests

Job reasons

none


Selection computed for commit 11f590e.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The production bundle refresh and embedded-install validation remain pending, alongside the review findings.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

Prepares CLI test coverage and documentation for the Project v2 migration skill without updating the production bundle.

Changes:

  • Adds the migration skill to the test bundle.
  • Tests installation, references, locations, and selection flows.
  • Adds migration guidance to the .NET hosting README.
File summaries
File Description
FakePlaywrightServices.cs Adds the migration skill fixture and excluded evaluation asset.
AgentInitCommandTests.cs Covers default, explicit, interactive, and chained installation.
README.md Links to the migration skill and summarizes its scope.
Review details
  • Files reviewed: 3/3 changed files
  • Comments generated: 2
  • Review effort level: Balanced (auto)

Note

Copilot is running an experiment and ran this review at Balanced.

> `AddDotnetProject` is experimental and is exposed under the `ASPIREDOTNETPROJECT001` diagnostic.
> Its API surface may change in future releases.

## Migrating from legacy project resources
});
using var provider = services.BuildServiceProvider();

// Exercise an incoming bundle without replacing the production embedded archive before its attested release.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants