Prepare Project v2 migration skill bundle integration - #20158
Karol Zadora-Przylecki (karolz-ms) wants to merge 1 commit into
Conversation
491f500 to
7c4c919
Compare
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 20158Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 20158" |
This comment has been minimized.
This comment has been minimized.
7c4c919 to
50ac60a
Compare
This comment has been minimized.
This comment has been minimized.
|
Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt. |
|
Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt. |
|
Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt. |
50ac60a to
cfb2dc7
Compare
This comment has been minimized.
This comment has been minimized.
|
Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt. |
|
Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt. |
|
Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt. |
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
cfb2dc7 to
11f590e
Compare
Tests selector1 / 99 PR test projects · 0 PR jobs, from 2 changed files. Selected PR test projects (1 / 99)
Selected PR jobs (0)none How these were chosen — grouped by what changed🧪 🧪 Job reasonsnone Selection computed for commit |
There was a problem hiding this comment.
🟡 Changes recommended
The production bundle refresh and embedded-install validation remain pending, alongside the review findings.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Prepares CLI test coverage and documentation for the Project v2 migration skill without updating the production bundle.
Changes:
- Adds the migration skill to the test bundle.
- Tests installation, references, locations, and selection flows.
- Adds migration guidance to the .NET hosting README.
File summaries
| File | Description |
|---|---|
FakePlaywrightServices.cs |
Adds the migration skill fixture and excluded evaluation asset. |
AgentInitCommandTests.cs |
Covers default, explicit, interactive, and chained installation. |
README.md |
Links to the migration skill and summarizes its scope. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 2
- Review effort level: Balanced (auto)
Note
Copilot is running an experiment and ran this review at Balanced.
| > `AddDotnetProject` is experimental and is exposed under the `ASPIREDOTNETPROJECT001` diagnostic. | ||
| > Its API surface may change in future releases. | ||
|
|
||
| ## Migrating from legacy project resources |
| }); | ||
| using var provider = services.BuildServiceProvider(); | ||
|
|
||
| // Exercise an incoming bundle without replacing the production embedded archive before its attested release. |
Description
Prepare the Aspire CLI integration for the approval-first
aspire-project-v2-migrationskill described in #19818.Important
This draft is based on #19997 and is not ready to merge. The production embedded skills archive has not been updated. Completing this PR requires an attested release containing microsoft/aspire-skills#65, followed by the bundle refresh and validation of the actual embedded installation.
Dependencies
Changes included
The product API changes belong to #20157, and the skill implementation belongs to microsoft/aspire-skills#65. Neither is duplicated here.
Required before merging
eng\scripts\update-aspire-skills-bundle.ps1 -Version <approved-version>and review the generated archive, metadata, installer/project, and any required hook updates.eng\scripts\verify-aspire-skills-bundle.ps1.mainafter DotnetProjectResource publishing #19997 merges and complete final integration review.Validation
The focused
AspireSkillsBundleTests,AspireSkillsInstallerTests, andAgentInitCommandTestsrun passed 131 tests, with no failures or skips.These checks validate the incoming-bundle installation path. They do not assert that the currently embedded archive already contains the new skill.
Part of #19818; the issue is not complete until the released bundle is integrated.
Checklist
<remarks />and<code />elements on your triple slash comments?