Skip to content

[WIP] Extend the Aspire Dashboard to reflect AppHost topology and publish an Azure Monitor Health Model - #20149

Open
James Gould (james-gould) wants to merge 30 commits into
microsoft:mainfrom
james-gould:ahm-graph-view
Open

James Gould (james-gould) wants to merge 30 commits into
microsoft:mainfrom
james-gould:ahm-graph-view

Conversation

@james-gould

Copy link
Copy Markdown
Contributor

Description

Currently WIP, please dogfood with the Aspire CLI and provide feedback if possible

Enhances the Graph view of the dashboard to reflect the AppHost's topology, reflecting the health state which propagates through the notes up to the AppHost root node.

Experimental, unstable changes

When aspire publish is executed, the health checks against the provisioned resource types are converted into Signal Definitions within an Azure Monitor health model. The intent is to allow some degree of customisation around the signal definitions created by default, along with disabling the provisioning of a health model altogether.

This PR is opened purely to expose the changes via the aspire CLI for dogfooding, feedback and easier testing. Some notes and feedback around how the topology is derived from the Aspire Discord may be integrated here or in a precursor PR:

  • OTel namespaces as extension methods, topology derives from those where possible
  • Make the colours less horrendous

Screenshots

image image

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 20149

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 20149"

@github-actions

Copy link
Copy Markdown
Contributor

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

@github-actions

Copy link
Copy Markdown
Contributor

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

@github-actions

Copy link
Copy Markdown
Contributor

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant