Quote msiexec arguments in the InstallerTests#40566
Open
OneBlue wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Quotes the path arguments passed to msiexec in the InstallerTests so paths containing spaces don't trigger msiexec's help UI and hang the tests.
Changes:
- Wrap product code and MSI path arguments in quotes in three msiexec invocations.
- Wrap the log file path in quotes as well.
JohnMcPMS
approved these changes
May 15, 2026
benhillis
approved these changes
May 15, 2026
dkbennett
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
The msiexec arguments can sometimes contain spaces. If that happens, msiexec displays a "help UI", which hangs the tests.
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed