Skip to content

Quote msiexec arguments in the InstallerTests#40566

Open
OneBlue wants to merge 1 commit into
masterfrom
user/oneblue/test-fix-8
Open

Quote msiexec arguments in the InstallerTests#40566
OneBlue wants to merge 1 commit into
masterfrom
user/oneblue/test-fix-8

Conversation

@OneBlue
Copy link
Copy Markdown
Collaborator

@OneBlue OneBlue commented May 15, 2026

Summary of the Pull Request

The msiexec arguments can sometimes contain spaces. If that happens, msiexec displays a "help UI", which hangs the tests.

PR Checklist

  • Closes: Link to issue #xxx
  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • Tests: Added/updated if needed and all pass
  • Localization: All end user facing strings can be localized
  • Dev docs: Added/updated if needed
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

Copilot AI review requested due to automatic review settings May 15, 2026 22:19
@OneBlue OneBlue requested a review from a team as a code owner May 15, 2026 22:19
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Quotes the path arguments passed to msiexec in the InstallerTests so paths containing spaces don't trigger msiexec's help UI and hang the tests.

Changes:

  • Wrap product code and MSI path arguments in quotes in three msiexec invocations.
  • Wrap the log file path in quotes as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants