cloudtest: skip WSLC test suite on Windows Server images#40559
Open
benhillis wants to merge 3 commits into
Open
cloudtest: skip WSLC test suite on Windows Server images#40559benhillis wants to merge 3 commits into
benhillis wants to merge 3 commits into
Conversation
The WSLC TAEF job consistently times out on Windows Server images because of a VMBus PowerOff hang during VM teardown on Server SKUs. Skip the wslc TAEF group on Server images until the host issue is resolved. The wsl1 and wsl2 groups continue to run on Server. Client images (rs_prerelease, win11-23h2, win10-22h2) are unchanged and still run all three groups. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
OneBlue
previously approved these changes
May 15, 2026
Collaborator
OneBlue
left a comment
OneBlue
left a comment
There was a problem hiding this comment.
I think this is OK for now, let's try to prioritize getting the server fix available in our CI so we can revert this ASAP
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the CloudTest CMake configuration to skip generating the WSLC (TAEF @TestCategory='WSLC') test group on Windows Server CloudTest images to avoid consistent timeouts caused by VM teardown hangs on Server SKUs.
Changes:
- Introduce a
CLOUDTEST_SERVER_IMAGESlist to identify Windows Server CloudTest images. - Guard the
wslcadd_test_groupemission so it is skipped when the current image is inCLOUDTEST_SERVER_IMAGES.
OneBlue
reviewed
May 15, 2026
Collaborator
OneBlue
left a comment
OneBlue
left a comment
There was a problem hiding this comment.
I think copilot's right on the variable issue, but LGTM once fixed
Use "${image}" instead of bare image in the IN_LIST condition for
clarity and to avoid relying on if() implicit variable lookup.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Companion change to the cloudtest/CMakeLists.txt skip: tag the fe_release image as `server: true` and gate the WSLC test job on `image.server` so the pipeline does not try to load a TestMap.xml that is no longer generated for the WS22+wslc combination. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member
Author
|
Validated against the nightly pipeline: the wslc tests - fe_release job now resolves to skipped cleanly while all other test phases run normally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Skip the WSLC TAEF group on Windows Server cloudtest images. The WSLC suite consistently times out on Server SKUs because of a VMBus PowerOff hang during VM teardown, which exhausts the cloudtest job timeout and blocks downstream signal.
Change
cloudtest/CMakeLists.txt: introduceCLOUDTEST_SERVER_IMAGES(currently just the WS2022 datacenter image) and only emit thewslcadd_test_groupwhen the image is not in that list.wsl1+wsl2jobs run as before;wslcjob is skipped.rs_prerelease,win11-23h2,win10-22h2): unchanged — still run all three groups.test.batruns are unaffected (no filter applied there).Reverting
When the host issue is fixed, remove the image from
CLOUDTEST_SERVER_IMAGES(or delete the list and the guard) to re-enable WSLC coverage on Server.