Skip to content

[Do not review] Port #40308 to master: add --volumes support to wslc container remove#40557

Draft
Copilot wants to merge 2 commits into
masterfrom
copilot/backup-branch-40308-master
Draft

[Do not review] Port #40308 to master: add --volumes support to wslc container remove#40557
Copilot wants to merge 2 commits into
masterfrom
copilot/backup-branch-40308-master

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 15, 2026

Summary of the Pull Request

  • Ported the CLI: Added volumes option to container remove command #40308 change set onto master.
  • Added --volumes (-v) support for wslc container remove and passed the remove-volumes flag through container deletion.
  • Added/ported E2E coverage for remove-with-volumes and remove-without-volumes behaviors.
  • Added localized help text for the new flag.

PR Checklist

  • Closes: Link to issue #xxx
  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • Tests: Added/updated if needed and all pass
  • Localization: All end user facing strings can be localized
  • Dev docs: Added/updated if needed
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

  • Cherry-picked commit 726e425b9433286beb80a2b8655a38aa66c852f6 from CLI: Added volumes option to container remove command #40308 and resolved one signature conflict in ContainerService.h to retain current master API shape for List(...).
  • Clarified new option text to "Remove volumes associated with the container".

Validation Steps Performed

  • clang-format --dry-run --Werror on all changed C++ files
  • python3 tools/devops/validate-localization.py
  • parallel_validation:
    • Code Review: completed (addressed string wording feedback; alias warning considered non-blocking in current command-specific context)
    • CodeQL: timed out per tool output
  • Full Windows build/TAEF test execution was not run in this Linux sandbox (Windows-only).

AmelBawa-msft and others added 2 commits May 15, 2026 17:53
Co-authored-by: AmelBawa-msft <104940545+AmelBawa-msft@users.noreply.github.com>
Agent-Logs-Url: https://github.com/microsoft/WSL/sessions/18ec95fc-f691-46d4-b9e5-443439b720b3

Co-authored-by: AmelBawa-msft <104940545+AmelBawa-msft@users.noreply.github.com>
Copilot AI requested a review from AmelBawa-msft May 15, 2026 17:59
@AmelBawa-msft AmelBawa-msft changed the title Port #40308 to master: add --volumes support to wslc container remove [Do not review] Port #40308 to master: add --volumes support to wslc container remove May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants