Skip to content

Strip fractional seconds in ParseDockerTimestamp #40495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
benhillis wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Strip fractional seconds in ParseDockerTimestamp #40495

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b5e0018
Strip fractional seconds in ParseDockerTimestamp
benhillis May 11, 2026
1a4c4b3
Address review: start timezone search past the fractional separator
benhillis May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/windows/wslcsession/WSLCContainer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,8 +306,19 @@ WSLCContainerNetworkType DockerNetworkModeToWSLCNetworkType(const std::string& m
std::uint64_t ParseDockerTimestamp(const std::string& timestamp)
{
// Docker timestamps are UTC ISO 8601, e.g. "2026-03-05T10:30:00.123456789Z".
// We only need epoch seconds, so strip the optional fractional component before parsing.
std::string normalized = timestamp;
if (const auto tPos = normalized.find('T'); tPos != std::string::npos)
Copy link
Copy Markdown
Collaborator

@OneBlue OneBlue May 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of doing this, I think we can just drop the %Z part of the format and std::chrono::parse() should just ignore the fractional second part

{
if (const auto dot = normalized.find('.', tPos + 1); dot != std::string::npos)
Comment on lines +309 to +313
{
const auto tzStart = normalized.find_first_of("Z+-", dot + 1);
normalized.erase(dot, (tzStart == std::string::npos) ? std::string::npos : tzStart - dot);
}
}

std::chrono::sys_seconds utcSeconds;
std::istringstream stream(timestamp);
std::istringstream stream(normalized);
stream >> std::chrono::parse("%FT%H:%M:%S%Z", utcSeconds);
THROW_HR_IF_MSG(E_INVALIDARG, stream.fail(), "Failed to parse timestamp '%hs'", timestamp.c_str());

Expand Down