Revert bundled fixes — to be submitted as separate PRs#40492
Closed
Copilot wants to merge 2 commits into
Closed
Conversation
5 tasks
…edback Agent-Logs-Url: https://github.com/microsoft/WSL/sessions/8dbc98eb-39b7-4be0-bd5e-6d1c04ebce61 Co-authored-by: benhillis <17727402+benhillis@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix Docker timestamp fractional seconds, snprintf buffer bug, LxtLogError args, and misc code/script cleanup
Revert bundled fixes — to be submitted as separate PRs
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts all changes from the previous commit per reviewer feedback that each fix should be its own PR.
Summary of the Pull Request
Reverts five changed files to their original state. The individual fixes (Docker timestamp parsing,
snprintfbuffer size,LxtLogErrorargs, PowerShell script hardening) will be resubmitted as focused, independent PRs.PR Checklist
Detailed Description of the Pull Request / Additional comments
Files reverted to original state:
src/windows/wslcsession/WSLCContainer.cppsrc/windows/wslcsession/WSLCSession.cpptest/linux/unit_tests/lxtfs.ctools/setup-dev-env.ps1tools/test/run-tests.ps1Planned follow-up PRs:
WSLCContainer.cpp—ParseDockerTimestampfractional-seconds fix + minor clarity/typo fixesWSLCSession.cpp— constant scoping and iterator style cleanuplxtfs.c—snprintfwrong-size buffer bug +LxtLogErrormissing format argstools/setup-dev-env.ps1—Test-Pathguard beforewinget configuretools/test/run-tests.ps1— parameter doc fix +$LASTEXITCODEpropagationValidation Steps Performed
Verified via
git diffthat all five files are identical to their pre-PR state.