Fix workspace/symbol crash on an inferred project without a program - #64642
Open
Mateusz Burzyński (Andarist) wants to merge 1 commit into
Open
Mateusz Burzyński (Andarist) wants to merge 1 commit into
Mateusz Burzyński (Andarist) wants to merge 1 commit into
Conversation
… project is up to date
typescript-automation
Bot
added
For Uncommitted Bug
Contributor
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
Copilot started reviewing on behalf of
Mateusz Burzyński (Andarist)
October 5, 2026 13:08
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The targeted fix and regression coverage address the initialization gap, with no unresolved review findings.
Review effort: Balanced
Findings: None
What changed in this PR
Fixes a language-server workspace/symbol crash when a newly created inferred project has no program.
Changes:
- Updates the inferred project's program even when the default project is unchanged.
- Adds a regression test covering an orphaned file and a subsequent workspace-symbol request.
| File | Description |
|---|---|
| tsc/internal/project/projectcollectionbuilder.go | Moves inferred-program updates outside the default-project change check. |
| tsc/internal/fourslash/tests/workspaceSymbolNewInferredProject_test.go | Tests the project transition that previously caused the crash. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes the issue reported here: #64623 (comment)