[ios][fix] Reverted a change that was causing regression and failing ST - #680
Open
Gaurav K (gauravkeshre) wants to merge 1 commit into
Open
Gaurav K (gauravkeshre) wants to merge 1 commit into
Gaurav K (gauravkeshre) wants to merge 1 commit into
Conversation
Gaurav K (gauravkeshre)
changed the title
Harika (P-Harika)
approved these changes
Apr 17, 2026
hggzm
approved these changes
Apr 29, 2026
hggzm
left a comment
hggzm
left a comment
Collaborator
There was a problem hiding this comment.
Approved. Targeted revert of the visibility check that was over-collapsing containers whose children toggle visibility at runtime. Restores prior behavior and unblocks the failing ST. LGTM.
Gaurav K (gauravkeshre)
enabled auto-merge
May 6, 2026 06:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Elements marked visible with all children marked iinvisible were treated as invisible.
This was causing ST failure.
Reverted the check in ACRContentStackView