fix: Reduce quota demand, add Bicep version guard, remove hardcoded VM credentials#396
Open
Roopan-Microsoft wants to merge 1 commit intodevfrom
Open
fix: Reduce quota demand, add Bicep version guard, remove hardcoded VM credentials#396Roopan-Microsoft wants to merge 1 commit intodevfrom
Roopan-Microsoft wants to merge 1 commit intodevfrom
Conversation
…ardcoded VM credentials - Reduce gptModelCapacity default from 150 to 30 TPM (addresses InsufficientQuota errors - 2.2% of failures) - Add bicep >= 0.33.0 to requiredVersions in azure.yaml and azure_custom.yaml (addresses InvalidTemplate errors - 43.2% of failures) - Remove hardcoded VM password fallback from main.bicep, main_custom.bicep, and main.json (OWASP A07:2021) - Add @minValue(1) constraint to gptModelCapacity parameter - Update docs to reflect new required VM credentials and reduced capacity default - Applied consistently across main.bicep, main_custom.bicep, main.json, and documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses 3 high-impact findings from the Modernize-your-code error analysis (telemetry: 2025-12-01 to 2026-04-06). Template currently has 61.1% success rate (229 failures / 588 provisions).
Changes
1. Add Bicep version guard (P1 - addresses 43.2% of failures)
Error: \InvalidTemplate\ — 99 occurrences, 35 machines. The #1 error category.
equiredVersions\ in both \�zure.yaml\ and \�zure_custom.yaml\
esourceInput<>\, null-forgiving \!\) but only guarded azd version. Users with older Bicep get cryptic compile errors. Now azd fails fast with a clear message.
2. Reduce default model capacity (P1 - addresses 2.2% of failures)
Error: \InsufficientQuota\ — 5 occurrences, 2 machines
3. Remove hardcoded VM credentials (SECURITY - OWASP A07:2021)
Issue: Hardcoded password \JumpboxAdminP@ssw0rd1234!\ visible in public repository
Files Changed (7 files)
Impact