Skip to content

Fix protobuf dependency vulnerabilities - #221

Merged
Hannes Schulz (temporaer) merged 1 commit into
microsoft:mainfrom
jsmith13:copilot/20261030-090553
Oct 30, 2026
Merged

Hannes Schulz (temporaer) merged 1 commit into
microsoft:mainfrom
jsmith13:copilot/20261030-090553

Conversation

@jsmith13

Copy link
Copy Markdown
Collaborator

Summary

  • upgrade vulnerable protobuf pins to 5.29.6, fixing CVE-2026-0994 and CVE-2025-4565
  • upgrade the coupled TensorBoard compatibility set to tensorboard==2.12.0 and tensorboardX==2.6.1
  • prevent unpinned Conda TensorBoard installs from replacing the secure resolution
  • constrain legacy PyTorch 1.9 install paths to numpy<2

A protobuf-only bump, as proposed by #219, does not resolve with TensorBoard 2.11.2 and breaks TensorboardX 2.4.1 at runtime. This updates the compatibility set together without changing Fairseq, PyTorch, model code, checkpoints, or training settings.

Validation

  • built clean pre-patch and patched Docker images successfully
  • docker/verify_environment.py and pip check pass in both images
  • loaded historical Graphormer redox checkpoint d5c5cb62cf17217eadfb5b334e568ced000e0f6eb5871ce81bd62851a4853f09
  • compared 20 inference outputs across batched, repeated, reversed-order, and singleton calls: 20/20 exact matches, maximum absolute difference 0.0
  • ran two deterministic fine-tuning epochs in both images: losses and gradient norms matched exactly at all four optimizer steps
  • final fine-tuned model hashes matched exactly; post-training predictions matched 8/8 with maximum absolute difference 0.0
  • TensorBoard event writing succeeded during fine-tuning with protobuf 5.29.6

Upgrade protobuf and its TensorBoard compatibility set together, and constrain legacy PyTorch install paths to NumPy 1.x.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 73a43260-b014-4bc6-b771-73152869fed1

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@temporaer
Hannes Schulz (temporaer) merged commit 170be78 into microsoft:main Oct 30, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants