Remove redundant delete utility tests from diskann-providers#958
Merged
JordanMaples merged 8 commits intomainfrom Apr 22, 2026
Merged
Remove redundant delete utility tests from diskann-providers#958JordanMaples merged 8 commits intomainfrom
JordanMaples merged 8 commits intomainfrom
Conversation
These tests are now covered by equivalent tests in diskann added in #953: - test_return_refs_to_deleted_vertex - test_is_any_neighbor_deleted - test_drop_deleted_neighbors - test_get_undeleted_neighbors Also removes the setup_inplace_delete_test helper and unused PartitionedNeighbors import. Part of #927. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #958 +/- ##
==========================================
- Coverage 89.47% 89.44% -0.03%
==========================================
Files 449 449
Lines 84038 83779 -259
==========================================
- Hits 75191 74935 -256
+ Misses 8847 8844 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
harsha-simhadri
approved these changes
Apr 21, 2026
arrayka
approved these changes
Apr 22, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes a set of deletion-related utility tests from diskann-providers that are intended to be redundant with equivalent coverage being added to diskann (via #953), and cleans up related helper/import usage.
Changes:
- Removed redundant deletion utility tests (
test_return_refs_to_deleted_vertex,test_is_any_neighbor_deleted,test_drop_deleted_neighbors,test_get_undeleted_neighbors) fromdiskann-providers. - Removed the
setup_inplace_delete_testhelper function used only by the deleted tests. - Dropped an unused
PartitionedNeighborsimport from the test module.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These tests are now covered by equivalent tests in diskann added in #953:
Also removes the setup_inplace_delete_test helper and unused PartitionedNeighbors import.
Part of #927.