-
Notifications
You must be signed in to change notification settings - Fork 409
[Master]-]Withholding Tax Entries are not generated at payment because the Withholding Tax. Prod. Posting Group field gets not transferred to the payment line #9479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
neeleshsinghal
wants to merge
7
commits into
main
Choose a base branch
from
bugs/Bug-639524-WHT-Prod-Posting-Group-not-transferred-to-payment1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+72
−0
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
87105ec
[Master]-]Withholding Tax Entries are not generated at payment becaus…
neeleshsinghal c83343d
change in fix
neeleshsinghal 46ca7ba
Handle General Journal Template List popup on Create Payment (CZ mult…
neeleshsinghal 7d3200e
Create dedicated Payments template so template lookup opens determini…
neeleshsinghal 8247b98
Replace Create Payment page-based test with direct Gen. Journal Line …
neeleshsinghal 835d97f
fixes
neeleshsinghal 6bae51a
re fix
neeleshsinghal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new event subscriber AssignWHTPostingGroupOnCreatePayment (WithholdingTaxJnlSubscriber.Codeunit.al) copies 'Wthldg.
Tax Prod. Post. Group' from the Withholding Tax Entry onto the Gen. Journal Line when a payment is created via the 'Create Payment' page. This is new production logic that changes financial posting data. The single test added in this PR (WithholdingTaxProductPostingGroupIsCopiedToWithholdingTaxEntry) only exercises direct invoice posting and asserts that the group is copied onto the Withholding Tax Entry - a pre-existing code path unrelated to the new subscriber. None of the existing 'Create Payment' related tests invoke the page's OnBeforeUpdateGnlJnlLineDimensionsFromVendorPayment event (they post payments directly through Gen. Journal Line, bypassing the page). As a result, the new subscriber's behavior - including its guard clauses (Applies-to ID blank, Vendor Ledg. Entry No. = 0, no matching Withholding Tax Entry) and the successful copy path - has no test coverage. Recommend adding a test that drives the 'Create Payment' page (or otherwise raises OnBeforeUpdateGnlJnlLineDimensionsFromVendorPayment) to verify the Gen. Journal Line's WHT Product Posting Group is populated correctly before posting.
Agent judgement — not directly backed by a BCQuality knowledge article.
👍 useful · ❤️ especially valuable · 👎 wrong - reply with why