[Extensibility Request] issue 30290: Add OnBeforeUpdateSetupOnBillToCustomerChangeInSalesHeader event#9450
Open
AleksandricMarko wants to merge 1 commit into
Open
[Extensibility Request] issue 30290: Add OnBeforeUpdateSetupOnBillToCustomerChangeInSalesHeader event#9450AleksandricMarko wants to merge 1 commit into
AleksandricMarko wants to merge 1 commit into
Conversation
…alesHeader event Add an IsHandled integration event before the AltCustVATRegFacade VAT registration setup call in SetBillToCustomerAddressFieldsFromCustomer so subscribers can skip the standard logic. Propagated across all layers. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Copilot PR ReviewIteration 1 · Outcome: completed Knowledge source: https://github.com/microsoft/BCQuality@186d8a131465475c79244d994acb872cd5c0d4bf Orchestrator pre-filter (2 file(s) excluded)
Findings produced by the AL review agent v1.7.3. Reply 👎 on any inline comment to flag false positives. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The issue author has a separate extension that already handles assignment of the VAT Registration No. and related posting groups when the bill-to customer changes on a sales header. Because
SetBillToCustomerAddressFieldsFromCustomeralways callsAltCustVATRegFacade.UpdateSetupOnBillToCustomerChangeInSalesHeader, the standard logic can overwrite or conflict with the values set by their feature. This PR adds anIsHandledintegration event so subscribers can skip that specific call while leaving the rest of the standard logic intact.Source issue repository: microsoft/AlAppExtensions; issue number: 30290
Changes Made
OnBeforeUpdateSetupOnBillToCustomerChangeInSalesHeader- NewIntegrationEventraised in theSetBillToCustomerAddressFieldsFromCustomerprocedure of tableSales Header, right before theAltCustVATRegFacade.UpdateSetupOnBillToCustomerChangeInSalesHeadercall.IsHandledis initialized tofalseand, when a subscriber sets it totrue, the standard call is skipped. The same change was propagated to every layer that has its own copy of the file.Fixes AB#641535