[Extensibility Request] issue 30173: add integration events to Sales Line Discounts page#9445
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Copilot PR ReviewIteration 1 · Outcome: completed Knowledge source: https://github.com/microsoft/BCQuality@809af9708e265f110ced6752fd8f2e40f1efc820 Findings by domainFindings split into Knowledge-backed (cite a BCQuality article) and Agent (the agent's own judgement, no matching BCQuality rule).
Totals: 3 knowledge-backed · 5 agent findings. Orchestrator pre-filter (2 file(s) excluded)
Findings produced by the Copilot CLI agent against BCQuality at |
JakovljevicDusan
approved these changes
Jul 15, 2026
6CRIPT
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The author is building an extension on top of page 7004 "Sales Line Discounts" with additional fields backed by page-level global variables, and needs extensibility hooks that were not previously available. Specifically, they need to influence record filtering during filter setup (with access to the page/rec context) and to resolve the filter description for item type filter values the base application does not handle. This PR adds two integration events on the page so partners can extend these flows without modifying base code.
Source issue repository: microsoft/ALAppExtensions; issue number: 30173
Changes Made
OnSetRecFiltersOnBeforeCurrPageUpdate- new integration event raised inSetRecFiltersafter all record filters are applied and beforeCurrPage.Update, exposing the sales line discount record and the current item type filter so subscribers can apply additional filtering. UsesIncludeSender = true(matching existing events on the page) to give subscribers access to the page instance.OnGetFilterDescriptionCaseElse- new integration event raised from theelsebranch added to theItemTypeFiltercase inGetFilterDescription, letting subscribers supply a custom source table name and item filtering for item type filter values other than Item and Item Discount Group.ItemTypeFilteroption type; the requested enum "Item Type Filter" is tracked separately (issue #30170) and does not yet exist in the codebase.Fixes AB#637953