Skip to content

[Main]-Payment XML file generated from EB Payment Journal upon selecting "FCY Symbol" includes currency text #9356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
neeleshsinghal merged 8 commits into from
Jul 16, 2026
Merged

[Main]-Payment XML file generated from EB Payment Journal upon selecting "FCY Symbol" includes currency text #9356

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
840dfae
FIx
neeleshsinghal Jul 13, 2026
c2dd6f0
Suggestion
neeleshsinghal Jul 14, 2026
6bca8af
Merge branch 'microsoft:main' into bugs/Bug-641821-Export-EB-Payment-…
neeleshsinghal Jul 14, 2026
adc328e
remove procedure
neeleshsinghal Jul 14, 2026
6e7f922
Merge branch 'bugs/Bug-641821-Export-EB-Payment-Journal-upon-FCY-Symb…
neeleshsinghal Jul 14, 2026
811ed60
Correct the automation
neeleshsinghal Jul 15, 2026
821dd61
Merge branch 'microsoft:main' into bugs/Bug-641821-Export-EB-Payment-…
neeleshsinghal Jul 15, 2026
88a2a63
Merge branch 'microsoft:main' into bugs/Bug-641821-Export-EB-Payment-…
neeleshsinghal Jul 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Layers/BE/BaseApp/Local/BankMgt/Payment/FileFCYSEPA00100109Pmts.Report.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -495,7 +495,7 @@ report 2000008 "File FCY SEPA 001.001.09 Pmts"
AddElement(XMLNodeCurr, 'Amt', '', '', XMLNewChild);
XMLNodeCurr := XMLNewChild;

AddElement(XMLNodeCurr, 'InstdAmt', Format(PmtJnlLine.Amount, 0, 9), '', XMLNewChild);
Comment thread
neeleshsinghal marked this conversation as resolved.
AddElement(XMLNodeCurr, 'InstdAmt', Format(PmtJnlLine.Amount, 0, '<Precision,2:2><Standard Format,9>'), '', XMLNewChild);
if PmtJnlLine."Currency Code" = '' then
ISOCurrCode := CopyStr(GLSetup."LCY Code", 1, 3)
else begin
Expand Down
2 changes: 1 addition & 1 deletion src/Layers/BE/BaseApp/Local/BankMgt/Payment/FileNonEuroSEPAPayments.Report.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -502,7 +502,7 @@ report 2000006 "File Non Euro SEPA Payments"
AddElement(XMLNodeCurr, 'Amt', '', '', XMLNewChild);
XMLNodeCurr := XMLNewChild;

AddElement(XMLNodeCurr, 'InstdAmt', Format(PmtJnlLine.Amount, 0, 9), '', XMLNewChild);
Comment thread
neeleshsinghal marked this conversation as resolved.
AddElement(XMLNodeCurr, 'InstdAmt', Format(PmtJnlLine.Amount, 0, '<Precision,2:2><Standard Format,9>'), '', XMLNewChild);
Comment thread
neeleshsinghal marked this conversation as resolved.
if PmtJnlLine."Currency Code" = '' then
ISOCurrCode := CopyStr(GLSetup."LCY Code", 1, 3)
else begin
Expand Down
2 changes: 1 addition & 1 deletion src/Layers/BE/BaseApp/Local/BankMgt/Payment/FileSEPA00100109Pmts.Report.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -484,7 +484,7 @@ report 2000007 "File SEPA 001.001.09 Pmts"
AddElement(XMLNodeCurr, 'Amt', '', '', XMLNewChild);
XMLNodeCurr := XMLNewChild;

AddElement(XMLNodeCurr, 'InstdAmt', Format(PmtJnlLine.Amount, 0, 9), '', XMLNewChild);
AddElement(XMLNodeCurr, 'InstdAmt', Format(PmtJnlLine.Amount, 0, '<Precision,2:2><Standard Format,9>'), '', XMLNewChild);
AddAttribute(XMLDomDoc, XMLNewChild, 'Ccy', 'EUR');
XMLNodeCurr := XMLNodeCurr.ParentNode;
AddElement(XMLNodeCurr, 'CdtrAgt', '', '', XMLNewChild);
Expand Down
2 changes: 1 addition & 1 deletion src/Layers/BE/BaseApp/Local/BankMgt/Payment/FileSEPAPayments.Report.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -485,7 +485,7 @@ report 2000005 "File SEPA Payments"
AddElement(XMLNodeCurr, 'Amt', '', '', XMLNewChild);
XMLNodeCurr := XMLNewChild;

AddElement(XMLNodeCurr, 'InstdAmt', Format(PmtJnlLine.Amount, 0, 9), '', XMLNewChild);
AddElement(XMLNodeCurr, 'InstdAmt', Format(PmtJnlLine.Amount, 0, '<Precision,2:2><Standard Format,9>'), '', XMLNewChild);
Comment thread
neeleshsinghal marked this conversation as resolved.
AddAttribute(XMLDomDoc, XMLNewChild, 'Ccy', 'EUR');
XMLNodeCurr := XMLNodeCurr.ParentNode;
AddElement(XMLNodeCurr, 'CdtrAgt', '', '', XMLNewChild);
Expand Down
21 changes: 21 additions & 0 deletions src/Layers/BE/Tests/Local/EBPaymentJournalExport.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1221,15 +1221,18 @@ codeunit 144008 "EB - Payment Journal Export"
Initialize();

// Preparation: create settings
SetShowCurrencyToFCYSymbolOnly();
CountryCode := FindCountryRegion();
Comment thread
neeleshsinghal marked this conversation as resolved.
ExportProtocol := CreateSEPAExportProtocol(false);

// Create payments
SetCurrencySymbol(ForeignCurrencyCode);
VendorSwift := GenerateBankAccSwiftCode();
VendorNo := CreateVendor(CountryCode, ExportProtocol, VendorSwift, VendorIbanTxt);
InvAmount1 := CreateAndPostPurchInv(VendorNo, false);
FirstForeignCurrencyCodeIso := ForeignCurrencyIso;
CreateForeignCurrency(SecondForeignCurrencyCode, SecondForeignCurrencyCodeIso);
SetCurrencySymbol(SecondForeignCurrencyCode);
ForeignCurrencyCode := SecondForeignCurrencyCode;
ForeignCurrencyIso := SecondForeignCurrencyCodeIso;
InvAmount2 := CreateAndPostPurchInv(VendorNo, false);
Comment thread
neeleshsinghal marked this conversation as resolved.
Expand Down Expand Up @@ -1999,6 +2002,24 @@ codeunit 144008 "EB - Payment Journal Export"
ForeignCurrency.Modify(true);
end;

local procedure SetShowCurrencyToFCYSymbolOnly()
var
GeneralLedgerSetup: Record "General Ledger Setup";
begin
GeneralLedgerSetup.Get();
GeneralLedgerSetup.Validate("Show Currency", GeneralLedgerSetup."Show Currency"::"FCY Symbol Only");
GeneralLedgerSetup.Modify(true);
end;
Comment thread
neeleshsinghal marked this conversation as resolved.

local procedure SetCurrencySymbol(CurrencyCode: Code[10])
var
Currency: Record Currency;
begin
Currency.Get(CurrencyCode);
Currency.Validate(Symbol, '$');
Currency.Modify(true);
end;

local procedure CreateSEPAExportProtocol(UseEuro: Boolean): Code[20]
var
ExportProtocol: Record "Export Protocol";
Expand Down
Loading