Re-enable BCPT Setup Card tests: fix NoOfSqlCallsAreLogged SQL assertion (Bug 618568)

[gggdttt]

Problem

Bug AB#618568. The test NoOfSqlCallsAreLogged in codeunit 144741 "BCPT Setup Card Test" was disabled during the platform 28.0.44646 uptake (PR 237052) because it started failing:

AssertEquals for Field: NoOfSQLStmts Expected = '5', Actual = '7'

Root cause

The test runs 5 iterations of BCPT Codeunit With 1 Sql (1 SQL statement each) and asserted NoOfSQLStmts = 5. However, the very first database access in a session also counts 2 extra SQL statements from system tables, making the total either 5 (iterations) or 7 (iterations + 2). This is the same non-determinism already documented in the sibling test LogsAreGeneratedAfterTheExecution, which accepts [0, 2] for a single entry.

AvgSQLStmts is computed via integer division (GetAvgSQLStmts = No. of SQL Statements div No. of Iterations), so 7 div 5 = 1 and 5 div 5 = 1 — the average assertion is unaffected.

Solution

Updated the assertion to accept the total being either the actual number of iterations or that number + 2, deriving the expectation from the measured iteration count rather than a hard-coded 5.

Changes

• src/Tools/Performance Toolkit/Test/src/BCPTSetupCardTest.Codeunit.al: tolerant NoOfSQLStmts assertion in NoOfSqlCallsAreLogged.

Testing

• AL static analysis: no diagnostics.
• Full validation pending CI (RunALTestDevTools) once the test is re-enabled (the corresponding NAV-side change removes the DisabledTests entry).

Related

• Re-enables tests disabled in PR 237052.
• Paired with the NAV (ADO) change removing App/DisabledTests/BCPTSetupCardTest.DisabledTest.json.

[github-actions]

Copilot PR Review

Iteration 4 · Outcome: no-knowledge

No BCQuality knowledge article applied to the single test-only change; the one style candidate considered (Error/Message/StrSubstNo wrapping) does not cover Assert.Fail/Assert.IsTrue calls.

Knowledge source: https://github.com/microsoft/BCQuality@822cae1b2771ac25f665f73369f69093bd4fd630

No findings were posted for this iteration.

Orchestrator pre-filter (13 file(s) excluded)

• layer-disabled (knowledge) : 13 file(s)

_{Findings produced by the Copilot CLI agent against BCQuality at 822cae1b2771ac25f665f73369f69093bd4fd630. Reply 👎 on any inline comment to flag false positives.}