[Bug]: External Storage - Document Attachments fails on Purch. Cr. Memo Hdr. due to trailing dot in generated SharePoint folder name

[SteveB0z]

Describe the issue

We are testing the integration between:
 

• External Storage - Document Attachments
• External File Storage - SharePoint Connector
   
  When attempting to upload a document attachment from a Posted Purchase Credit Memo, the upload fails with the following error:

Expected behavior

Before creating folders in SharePoint, the connector should sanitize folder names and remove invalid trailing characters "." (and other character not supported by sharepoint).

For Example "Purch. Cr. Memo Hdr." should became "Purch._Cr._Memo_Hdr"

Steps to reproduce

1. Configure External File Storage - SharePoint Connector
2. Configure a valid SharePoint site
3. Enable external storage for Document Attachments
4. Open "Posted Purchase Credit Memos" and upload an attachment

Additional context

Business Central 28.5 SaaS
External Storage - Document Attachments
External File Storage - SharePoint Connector
No legacy API

I will provide a fix for a bug

• I will provide a fix for a bug

Suggested fix

codeunit 8751 "DA External Storage Impl." implements "File Scenario"

Current code:

 local procedure GetTableNameFolder(TableID: Integer): Text[100]
    var
        TableName: Text;
    begin
        // Try to get table name from metadata, fallback to table ID if not available
        if not TryGetTableName(TableID, TableName) then
            TableName := 'Table_' + Format(TableID);

        // Replace invalid characters for folder names
        TableName := DelChr(TableName, '=', '<>:"/\|?*');
        TableName := ConvertStr(TableName, ' ', '_');

        exit(CopyStr(TableName, 1, 100));
    end;

New code:

procedure GetTableNameFolder(TableID: Integer): Text[100]
 var
     TableName: Text;
 begin
     // Try to get table name from metadata, fallback to table ID if not available
     if not TryGetTableName(TableID, TableName) then
         TableName := 'Table_' + Format(TableID);

     // Replace invalid characters for folder names
     TableName := DelChr(TableName, '=', '<>:"/\|?*');
     TableName := ConvertStr(TableName, ' ', '_');
     **TableName := DelChr(TableName, '>', '. ');**

     exit(CopyStr(TableName, 1, 100));
 end;

[github-actions]

🤖 AI Triage Assessment

⚠️ Partial triage — enrichment phase failed. Only quality assessment is available.

Verdict	Quality
NEEDS WORK	42/100

Summary: Phase 1 assessment failed; defaulting to NEEDS WORK for manual review.

Please try removing and re-adding the ai-triage label to retry full triage.