Fix E2E tests hanging indefinitely during PR validation#4906
Closed
Copilot wants to merge 2 commits into
Closed
Conversation
…om summary, fix asyncio mark Agent-Logs-Url: https://github.com/microsoft/AzureTRE/sessions/bc627f57-dcc6-4fc5-b80c-17f541d3859e Co-authored-by: rudolphjacksonm <13438569+rudolphjacksonm@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix E2E tests hanging during PR validation
Fix E2E tests hanging indefinitely during PR validation
May 20, 2026
Collaborator
|
/test |
|
🤖 pr-bot 🤖
(in response to this comment from @rudolphjacksonm) |
Collaborator
|
/test 8c907df |
|
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/26193010183 (with refid (in response to this comment from @rudolphjacksonm) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
summaryjob indeploy_tre_reusable.ymlhad several issues that caused the "Deploy PR / Run E2E Tests (Smoke)" check to remain permanently stuck inin_progressstate, making E2E tests appear to hang indefinitely from the PR perspective.What is being addressed
When triggering E2E tests via
/testcomment, the "Deploy PR / Run E2E Tests (Smoke)" check would remainin_progressforever and tests would never be reported as completed. Additionally,test_shared_service_templates.pywas missing the asyncio loop scope marker present in all other test files.How is this addressed
summaryjob fixes (deploy_tre_reusable.yml):actions: readpermission — required byim-open/workflow-conclusionto calllistJobsForWorkflowRunAPI. Without it, the action fails silently, theWORKFLOW_CONCLUSIONenv var is never set, and the check status update is skippedenvironment: ${{ inputs.environmentName }}— thesummaryjob accesses no environment variables or secrets; having it set means each workflow run requires a separate per-job environment approval, blocking the job unnecessarilyReport check statusstep condition fromif: inputs.prHeadSha != ''toif: always() && inputs.prHeadSha != ''— ensures the check is updated tocompletedeven ifworkflow-conclusionfailsCalling workflows (
pr_comment_bot.yml,deploy_tre.yml,deploy_tre_branch.yml):actions: readto the job-levelpermissionsblock so the permission propagates into the reusable workflowtest_shared_service_templates.py:pytestmark = pytest.mark.asyncio(loop_scope="session")to match every other test file and eliminate event loop scope inconsistency with pytest-asyncio 0.24.0CHANGELOG.md: Updated with bug fix entry.