Reset noise floor samples after frequency changes#10752
Open
RCGV1 wants to merge 1 commit into
Open
Conversation
Contributor
⚡ Try this PR in the Web FlasherWarning This is an automated, unreviewed CI test build. Back up your device configuration Supported boards built by this PR (22)
Build artifacts expire on 2026-07-22. Updated for |
Contributor
|
This probably should target master |
Contributor
|
Now that it targets master, it needes to be rebased. We don't want to merge develop into master yet |
ae55fc4 to
9604fe5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
reconfigure()applies a different effective receiver frequency.RadioLibInterface; all RadioLib chip drivers already call this base reconfigure path before applying chip-specific settings.test_radiocoverage that seeds RadioLib noise-floor state, verifies it is cleared when frequency changes, and verifies it is preserved when frequency is unchanged.Why this is needed
LoRa config changes do not generally reboot the node.
AdminModule::handleSetConfig()explicitly setsrequiresReboot = falsefor LoRa config, thensaveChanges()callsMeshService::reloadConfig(), which notifies the radio config observer and reconfigures the radio live. Channel changes also save without reboot and flow through reloadConfig; this matters because the default frequency slot can be derived from the primary channel name.Testing
trunk fmt src/mesh/RadioInterface.h src/mesh/RadioInterface.cpp src/mesh/RadioLibInterface.h src/mesh/RadioLibInterface.cpp test/test_radio/test_main.cpp~/.platformio/penv/bin/python -m platformio test -e native-macos -f test_radio: 17 passedpio run -e heltec-v3: SUCCESSNotes
~/.platformio/penv/bin/python -m platformio test -e native -f test_radioon macOS, but it failed before test execution because LovyanGFX includes Linux-only<malloc.h>. The repo hasnative-macosfor this case, and that target passed.