fix: dynamically assign button pin to prevent false interrupts#10742
Open
LN4CY wants to merge 1 commit into
Open
fix: dynamically assign button pin to prevent false interrupts#10742LN4CY wants to merge 1 commit into
LN4CY wants to merge 1 commit into
Conversation
Contributor
⚡ Try this PR in the Web FlasherNote Building this pull request… the flash button, badges and supported-board |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves the false interrupt and random wake issues caused by floating button pins on variants where the button is not physically wired (such as
rak3401_1watt), while fully restoring button functionality when a GPIO is explicitly assigned via the Meshtastic configuration.Changes Made:
#ifdef BUTTON_PINguards inInputBroker.cpp,PowerFSM.cpp,sleep.cpp, andmain-esp32.cppin favor of#if HAS_BUTTON._btnPinusing the following priority:config.device.button_gpio(if explicitly assigned at runtime)USERPREFS_BUTTON_PIN(if defined in userprefs)BUTTON_PIN(if defined in the variant header)0xFF), the firmware skips configuring the button pull-ups, skips initializingButtonThread, and ignores digital reads during sleep, avoiding any false positives on floating pins.?? Attestations
Fixes #10574