Skip to content

moo/MOO-2223 fixed the clear text voiceover issue in textfilter widget for main branch #462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
saurabhchavan1711 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

moo/MOO-2223 fixed the clear text voiceover issue in textfilter widget for main branch #462

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/pluggableWidgets/gallery-text-filter-native/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),

## [Unreleased]

### Fixed

- Fixed VoiceOver/TalkBack not announcing the clear text button.

## [2.0.1] - 2025-12-15

- Updated react-native-svg to v15.12.1. This addresses compatibility issues with React Native 0.78 and later versions.
Expand Down
2 changes: 1 addition & 1 deletion packages/pluggableWidgets/gallery-text-filter-native/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "gallery-text-filter-native",
"widgetName": "GalleryTextFilter",
"version": "2.0.1",
"version": "2.0.2",
"license": "Apache-2.0",
"copyright": "© Mendix Technology BV 2022. All rights reserved.",
"repository": {
Expand Down
2 changes: 2 additions & 0 deletions packages/pluggableWidgets/gallery-text-filter-native/src/components/FilterComponent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
</Svg>
);

useEffect(() => props.updateFilters?.(value), [value]);

Check warning on line 47 in packages/pluggableWidgets/gallery-text-filter-native/src/components/FilterComponent.tsx

View workflow job for this annotation

GitHub Actions / Unit tests 

React Hook useEffect has a missing dependency: 'props'. Either include it or remove the dependency array. However, 'props' will change when *any* prop changes, so the preferred fix is to destructure the 'props' object outside of the useEffect call and refer to those specific props inside useEffect

useEffect(() => {
setValueInput(props.value ?? "");
Expand Down Expand Up @@ -95,6 +95,8 @@
/>
{value !== "" ? (
<TouchableOpacity
accessibilityRole="button"
accessibilityLabel="Clear text"
testID={`${props.name}-clear-text-button`}
onPress={onPressClearTextIcon}
style={props.styles?.textInputClearIcon}
Expand Down
2 changes: 1 addition & 1 deletion packages/pluggableWidgets/gallery-text-filter-native/src/package.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="utf-8" ?>
<package xmlns="http://www.mendix.com/package/1.0/">
<clientModule name="GalleryTextFilter" version="2.0.1" xmlns="http://www.mendix.com/clientModule/1.0/">
<clientModule name="GalleryTextFilter" version="2.0.2" xmlns="http://www.mendix.com/clientModule/1.0/">
<widgetFiles>
<widgetFile path="GalleryTextFilter.xml" />
</widgetFiles>
Expand Down
Loading