feat(#10548): add TASK, TARGET, USER_SETTINGS constants to DOC_TYPES#11239
Open
AshayK003 wants to merge 2 commits into
Open
feat(#10548): add TASK, TARGET, USER_SETTINGS constants to DOC_TYPES#11239AshayK003 wants to merge 2 commits into
AshayK003 wants to merge 2 commits into
Conversation
…YPES Adds DOC_TYPES.TASK, DOC_TYPES.TARGET, and DOC_TYPES.USER_SETTINGS constants and replaces magic-string usages across the codebase. Closes medic#10548
Author
|
Hi maintainers 👋 This PR adds DOC_TYPES.TASK, DOC_TYPES.TARGET, and DOC_TYPES.USER_SETTINGS constants to the shared constants library and replaces all corresponding magic-string usages across the codebase (6 files, +13/−8). Closes #10548. Could someone please take a look when you get a chance? The CI checks appear to need a maintainer's approval to run from this fork. Happy to address any feedback. |
Author
|
@maintainers Bumping for visibility. This adds 3 missing constants (TASK, TARGET, USER_SETTINGS) to the shared DOC_TYPES library and replaces magic strings across 4 files. SonarCloud warnings are all pre-existing in files touched by the diff, not introduced by this change. Happy to address any feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds DOC_TYPES.TASK, DOC_TYPES.TARGET, and DOC_TYPES.USER_SETTINGS constants to the shared constants library and replaces all magic-string usages in production code.
Changes (6 files, +13/−8):
'user-settings'and'task''target''task'/'target''task'(import existed)'task'(import existed)Not changed — CouchDB ddoc files (sandboxed context), form.service.ts (FormType), E2E tests.
Closes #10548