Add Docker container discovery#3
Open
Spadav wants to merge 1 commit into
Open
Conversation
|
@Spadav is attempting to deploy a commit to the Mohamed Meabed's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add optional Docker container discovery behind
--docker.tsppreviously only discovered host listeners fromlsof/netstat, so containers without a visible host process could bemissed or shown as generic Docker proxy listeners. This change adds Docker as a second discovery source by reading the local
Docker API over
/var/run/docker.sock.Docker discovery:
GET /containers/jsonlsoflisteners taking priorityThe feature is wired through:
start --dockerlist --dockerstatus --dockerdoctor --dockerconfigure --dockerSafety / Risk
This is opt-in and read-only. It only sends Docker API
GETrequests and does not create, modify, stop, or remove containers.The main operational caveat is that the user running
tspmust have permission to access/var/run/docker.sock. Docker socketaccess is privileged in general, so users should only enable this on machines where they already trust the local user/session.
Testing
go test ./...go vet ./...tsp list --docker --all --ports 3000-9000against local running Docker containers