Repository navigation
[Sentry MBTA-DOTCOM-13G] FunctionClauseError: no function clause matching in Access.get/3 - #3678
Merged
Merged
Conversation
…ameters passed in the URL are not (crawlers)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Asana Ticket: [Sentry MBTA-DOTCOM-13G] FunctionClauseError: no function clause matching in Access.get/3
Implementation
It looks like crawlers are guessing at params and causing errors.
I added logic to force
schedule_directionto be a map even when the parameters passed in via URL are notScreenshots
N/A
How to test
http://mbta.com/schedules/350/line?schedule_direction=0 (Crashes)
http://localhost:4001/schedules/350/line?schedule_direction=0 (Doesn't!)