Skip to content

[Line Diagram][Stop Card] Show platform names according to the same rules as the departures page - #3665

Merged
lvachon1 merged 37 commits into
mainfrom
lev/line_diagram/platform_names
Nov 13, 2026
Merged

lvachon1 merged 37 commits into
mainfrom
lev/line_diagram/platform_names

Conversation

@lvachon1

@lvachon1 lvachon1 commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Scope

Asana Ticket: 💈🎣 [Bus] Show platform names according to the same rules as the departures page

Implementation

Added a bit of layout and logic to use Dotcom.ScheduleFinder.Platforms.has_platforms? when deciding whether to show @stop.platform_name or not.

Builds upon #3662 and #3640 If those are merged first then this PR should look much simpler. (✅ Done, and it does)

Screenshots

Screenshot 2026-11-04 at 1 59 02 PM

How to test

http://localhost:4001/schedules/19/line_new has a good amount of stops with platform names.

…then filter that by the search phrase. Fixed case-sensitivity of the stop search.
…uld be called for each route, used that for the search UI on the new line diagram
…te connecting routes for each stop. Next step is to make them look good.
…ls. The ferry and commuter icons are smaller than the rest though....
…ons to better fit with the Green Line icons and the Text Based Bus Pills
… is updated. Updated handle_params so that it recomputes the "other" stops when variant or direction changes.
…iagram/platform_names

# Conflicts:
#	lib/dotcom_web/live/line_diagram_live.ex
#	priv/gettext/es/LC_MESSAGES/dotcom.po
#	priv/gettext/fr-FR/LC_MESSAGES/dotcom.po
#	priv/gettext/ht/LC_MESSAGES/dotcom.po
#	priv/gettext/pt-BR/LC_MESSAGES/dotcom.po
#	priv/gettext/vi/LC_MESSAGES/dotcom.po
#	priv/gettext/zh-CN/LC_MESSAGES/dotcom.po
#	priv/gettext/zh-TW/LC_MESSAGES/dotcom.po
@lvachon1
lvachon1 marked this pull request as ready for review November 12, 2026 18:17
@lvachon1
lvachon1 requested a review from a team as a code owner November 12, 2026 18:17
@lvachon1
lvachon1 requested a review from jlucytan November 12, 2026 18:17
@lvachon1
lvachon1 merged commit 1b045cb into main Nov 13, 2026
25 checks passed
@lvachon1
lvachon1 deleted the lev/line_diagram/platform_names branch November 13, 2026 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants