handle*: add option to bridge polls with a provisioning API for fetching results by iFixRobots · Pull Request #1135 · mautrix/telegram

iFixRobots · 2026-10-29T21:48:37Z

With extev_polls enabled, Telegram polls are sent as MSC3381 polls and clients fetch the current results through the poll results provisioning API from mautrix/go#658, since votes aren't tied to a message and anonymous votes aren't visible at all. Polls and votes from Matrix are sent with sendMedia/sendVote.

Tag @indent to continue the conversation here.

indent · 2026-10-29T21:48:43Z

Issues

All clear! No issues remaining. 🎉

4 issues already resolved

Bot logins advertise Poll and PollResultsAPI even though Telegram bots can't call messages.sendVote or messages.getPollResults, so voting and GET /v3/poll_results always fail for them. Capabilities are also advertised when extev_polls is off, while Telegram-created polls arrive as text. (fixed by commit e143fc3)
_{Found by Indent Review Agent}
The partial multi-choice vote overwrite is fixed, but getPollVotes is still called synchronously on every min updateMessagePoll (where mine is nil) with no throttle. It fails with POLL_VOTE_REQUIRED until the user votes and can FLOOD_WAIT, adding an RPC and a warning log per vote. (fixed by commit 70a4015)
_{Found by Indent Review Agent}
One failing getPollResults (deleted poll, flood wait) aborts refresh of the remaining polls, and in HandleMatrixViewingChat the returned error also skips sponsored-message polling, repeating on every view. (fixed by commit 5280ce2)
_{Found by Indent Review Agent}
go.mod pins maunium.net/go/mautrix to the head of the still-open bridgev2: add provisioning API for fetching poll results go#658, a commit that exists only on that feature branch. The poll APIs this PR uses aren't on mautrix/go main, so re-pin to the merge commit or a release after Leave a Portal Room without leaving the matrix channel #658 merges and before merging this PR. go.sum is now tidy. (fixed by commit 4d08e8a)
_{Found by Indent Review Agent}

CI Checks

All required CI checks passed on e2bbb04.

Review agents

Select any unchecked box below to run or rerun that agent.

Passed (1)

Indent Review Agent · Only nits left: max_selections, vote receipts

Full results

Indent Review Agent

Summary: Only nits left: max_selections, vote receipts
Last ran on commit: e2bbb04d

Latest result

{
  "summary": "Only nits left: max_selections, vote receipts",
  "findings": [
    {
      "fix": "Use `MaxSelections > 1`.",
      "line": 164,
      "path": "pkg/connector/polls.go",
      "issue": "Still present. `MultipleChoice: MaxSelections != 1` treats a missing `max_selections` (parsed as 0) as multiple choice. MSC3381 says the default is 1.",
      "title": "Matrix polls without max_selections become multiple-choice",
      "severity": "nit"
    },
    {
      "fix": "Don't save vote rows under the poll's message ID (use a separate synthetic ID), or don't save a DB row for votes.",
      "line": 231,
      "path": "pkg/connector/polls.go",
      "issue": "Still present. Matrix votes are saved as extra parts with the poll's message ID and PartID `vote:$event`. bridgev2's `handleRemoteReadReceipt` resolves targets with `GetLastPartByID` (ORDER BY part_id DESC), so a Telegram read receipt pointing at the poll lands on the user's latest vote event. That event can be much later in the Matrix timeline, which marks newer messages as read.",
      "title": "Remote read receipts on a voted poll land on the vote event",
      "severity": "nit"
    }
  ]
}

…dging votes

tulir · 2026-10-30T15:05:16Z

 		feat.DeleteChat = topicID == 0
 	case ids.PeerTypeUser:
 		baseID += "+dm"
+		feat.Poll = event.CapLevelRejected


Hmm, telegram allows forwarding polls into DMs, I wonder if sending new ones is actually blocked or just hidden in the UI

tulir · 2026-10-30T15:23:37Z

+# Should polls be sent using unstable MSC3381 event types? Votes aren't bridged as events,
+# clients fetch the current results with the poll results provisioning API instead.


The provisioning API detail is fairly irrelevant for people reading this

Suggested change

# Should polls be sent using unstable MSC3381 event types? Votes aren't bridged as events,

# clients fetch the current results with the poll results provisioning API instead.

# Should polls be sent using unstable MSC3381 event types?

# Bridging votes from Telegram is not supported.

tulir · 2026-10-30T15:28:20Z

+		"org.matrix.msc3381.poll.start": map[string]any{
+			"kind":           kind,
+			"max_selections": maxSelections,
+			"question": map[string]any{
+				"org.matrix.msc1767.text": poll.Poll.Question.Text,
+			},
+			"answers": msc3381Answers,
 		},


There's a struct for this so it's nicer to use that

Suggested change

"org.matrix.msc3381.poll.start": map[string]any{

"kind": kind,

"max_selections": maxSelections,

"question": map[string]any{

"org.matrix.msc1767.text": poll.Poll.Question.Text,

},

"answers": msc3381Answers,

},

"org.matrix.msc3381.poll.start": &event.PollStart{

Kind: kind,

MaxSelections: maxSelections,

Question: event.MSC1767Message{

Text: poll.Poll.Question.Text,

},

Answers msc3381Answers,

},

tulir · 2026-10-30T15:28:30Z

 	poll := media.(*tg.MessageMediaPoll)
 	var textAnswers []string
 	var htmlAnswers strings.Builder
+	msc3381Answers := make([]map[string]any, 0, len(poll.Poll.Answers))


Suggested change

msc3381Answers := make([]map[string]any, 0, len(poll.Poll.Answers))

msc3381Answers := make([]event.PollOption, 0, len(poll.Poll.Answers))

tulir · 2026-10-30T15:28:55Z

+			msc3381Answers = append(msc3381Answers, map[string]any{
+				"id":                      pollAnswerID(nil, answer.Option),
+				"org.matrix.msc1767.text": text,
+			})


Suggested change

msc3381Answers = append(msc3381Answers, map[string]any{

"id": pollAnswerID(nil, answer.Option),

"org.matrix.msc1767.text": text,

})

msc3381Answers = append(msc3381Answers, event.PollOption{

ID: pollAnswerID(nil, answer.Option),

Text: text,

})

tulir · 2026-10-30T15:29:59Z

+		"org.matrix.msc1767.message": []map[string]any{
+			{"mimetype": "text/html", "body": part.Content.FormattedBody},
+			{"mimetype": "text/plain", "body": part.Content.Body},
+		},


I think nothing actually reads this so let's leave it out

Suggested change

"org.matrix.msc1767.message": []map[string]any{

{"mimetype": "text/html", "body": part.Content.FormattedBody},

{"mimetype": "text/plain", "body": part.Content.Body},

},

tulir · 2026-10-30T15:33:41Z

+			"kind":           kind,
+			"max_selections": maxSelections,
+			"question": map[string]any{
+				"org.matrix.msc1767.text": poll.Poll.Question.Text,


I think both questions and answers on telegram polls can have formatting, which is probably worth bridging if it doesn't complicate this too much

(they can also have media, but that part is definitely complicated, so let's leave it out for now)

tulir · 2026-10-30T15:38:16Z

+func pollAnswerID(meta *PollMetadata, option []byte) string {
+	answerID := base64.RawURLEncoding.EncodeToString(option)
+	if meta != nil {
+		if mxID, ok := meta.MatrixAnswerIDs[answerID]; ok {
+			return mxID
+		}
+	}
+	return answerID
+}
+
+func pollOption(meta *PollMetadata, answerID string) ([]byte, error) {
+	for option, mxID := range meta.MatrixAnswerIDs {
+		if mxID == answerID {
+			return base64.RawURLEncoding.DecodeString(option)
+		}
+	}
+	return base64.RawURLEncoding.DecodeString(answerID)
+}


should call these telegramToMatrixAnswerID and matrixToTelegramPollOption for a bit more clarity

…ot DMs

iFixRobots · 2026-10-30T16:15:01Z

@tulir - It's blocked server side, sending one to a user DM gave us MEDIA_INVALID. tdlib has the same check, forwards are allowed and so are bots and saved messages, so I opened up the capability for those two.

polls: bridge polls with public voters in both directions

e5c29db

iFixRobots requested a review from tulir October 29, 2026 21:51

indent Bot reviewed Oct 29, 2026

View reviewed changes

Comment thread pkg/connector/capabilities.go Resolved

indent Bot reviewed Oct 29, 2026

View reviewed changes

Comment thread pkg/connector/polls.go Resolved

indent Bot reviewed Oct 29, 2026

View reviewed changes

Comment thread pkg/connector/handlematrix.go Resolved

iFixRobots added 3 commits October 29, 2026 21:54

polls: don't send partial votes and keep refreshing after a failed poll

5280ce2

polls: don't fetch voters before voting on min results

70a4015

polls: fetch poll results through the provisioning API instead of bri…

fc19e8e

…dging votes

indent Bot changed the title ~~polls: bridge polls with public voters in both directions~~ polls: bridge polls and fetch results through the provisioning API Oct 29, 2026

iFixRobots added 6 commits October 29, 2026 22:58

capabilities: don't advertise polls for bot logins

e143fc3

dependencies: update mautrix-go

55c9793

dependencies: tidy go.sum

1843da3

dependencies: update mautrix-go

378d944

dependencies: update mautrix-go

508896f

dependencies: update mautrix-go

4d08e8a

tulir reviewed Oct 30, 2026

View reviewed changes

polls: use poll event structs, bridge formatting and allow polls in b…

e2bbb04

…ot DMs

iFixRobots requested a review from tulir October 30, 2026 16:48

tulir changed the title ~~polls: bridge polls and fetch results through the provisioning API~~ handle*: add option to bridge polls with a provisioning API for fetching results Oct 30, 2026

tulir approved these changes Oct 30, 2026

View reviewed changes

iFixRobots merged commit 83d7e6b into main Oct 30, 2026
12 checks passed

iFixRobots deleted the iFixRobots/polls branch October 30, 2026 17:04

Navigation Menu

Repository navigation

handle*: add option to bridge polls with a provisioning API for fetching results - #1135

handle*: add option to bridge polls with a provisioning API for fetching results#1135
iFixRobots merged 11 commits into
mainfrom
iFixRobots/polls

iFixRobots commented Oct 29, 2026 •

edited by indent Bot

Loading

Uh oh!

indent Bot commented Oct 29, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tulir Oct 30, 2026

Uh oh!

tulir Oct 30, 2026

Uh oh!

tulir Oct 30, 2026

Uh oh!

tulir Oct 30, 2026

Uh oh!

tulir Oct 30, 2026

Uh oh!

tulir Oct 30, 2026

Uh oh!

tulir Oct 30, 2026

Uh oh!

tulir Oct 30, 2026

Uh oh!

iFixRobots commented Oct 30, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

		# Should polls be sent using unstable MSC3381 event types? Votes aren't bridged as events,
		# clients fetch the current results with the poll results provisioning API instead.

	msc3381Answers := make([]map[string]any, 0, len(poll.Poll.Answers))
	msc3381Answers := make([]event.PollOption, 0, len(poll.Poll.Answers))

Conversation

iFixRobots commented Oct 29, 2026 • edited by indent Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

indent Bot commented Oct 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

iFixRobots commented Oct 30, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

iFixRobots commented Oct 29, 2026 •

edited by indent Bot

Loading

indent Bot commented Oct 29, 2026 •

edited

Loading