Repository navigation
crypto: drop cached own cross-signing keys when they change on the server - #635
Open
iFixRobots wants to merge 1 commit into
Open
iFixRobots wants to merge 1 commit into
iFixRobots wants to merge 1 commit into
Conversation
tulir
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When another device resets cross-signing,
storeCrossSigningKeysclears the cached public keys, butGetOwnCrossSigningPublicKeysrebuilds them frommach.CrossSigningKeys, which still holds the old private keys. SAS then sends the old master key in the MAC and rejects the new one withunknown key ID, so the device can't be verified again until it restarts. This drops the cached private keys when the server's own keys no longer include them.Tag
@indentto continue the conversation here.