fix: expose dedup load panic to waiters#25157
Open
jiangxinmeng1 wants to merge 1 commit into
Open
Conversation
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
jiangxinmeng1
force-pushed
the
fix/dedup-load-panic-error
branch
from
88c75ee to
8e21b56
Compare
matrix-meow
added
size/XS
matrix-meow
added
size/S
jiangxinmeng1
force-pushed
the
fix/dedup-load-panic-error
branch
from
5a4cda7 to
3f558a0
Compare
matrix-meow
added
size/XS
jiangxinmeng1
force-pushed
the
fix/dedup-load-panic-error
branch
from
3f558a0 to
6e1076f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue(s) this PR fixes:
issue #25129
What this PR does / why we need it:
What changed
When the owner goroutine in
dedupLoadpanics while runningload(), convert the panic value intocall.errbefore re-panicking.This keeps the owner behavior unchanged, but allows concurrent waiters to see the real failure reason instead of the generic
dedup load did not completesentinel.Why
After #24387, waiters are woken up when the owner exits, but if the owner panicked they could only observe the sentinel error. That hides the actual root cause, such as corrupt metadata, nil cached data, or decode
panics.