fix lockservice orphan remote txn validation#25154
Open
LeftHandCold wants to merge 1 commit into
Open
Conversation
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
XuPeng-SH
approved these changes
Jun 25, 2026
iamlinjunhong
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue(s) this PR fixes:
issue #25126
issue #22791
What this PR does / why we need it:
Backport of #25150 to 4.0-dev.
Remote lock orphan cleanup used to treat a missing remote CN active transaction as enough proof that the holder could be unlocked. That is unsafe when the commit response is lost after TN has already accepted or is processing the commit: the waiter can release the holder lock with an empty commit timestamp and continue on an old snapshot.
This PR makes the remote orphan check ask the allocator before releasing such a holder. If the allocator reports the txn is still committing, lockservice keeps the holder valid and does not unlock it as an orphan. Only txns confirmed as not committing continue down the orphan unlock path.
A unit test covers the inactive-remote-txn plus committing-in-allocator case so the waiter orphan cleanup path does not regress.
Test