Skip to content

cherrypick: fix lower case db name#25148

Open
daviszhen wants to merge 2 commits into
matrixorigin:mainfrom
daviszhen:0625-pick-3.0-to-main-proteced-db
Open

cherrypick: fix lower case db name#25148
daviszhen wants to merge 2 commits into
matrixorigin:mainfrom
daviszhen:0625-pick-3.0-to-main-proteced-db

Conversation

@daviszhen

@daviszhen daviszhen commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

What type of PR is this?

  • API-change
  • BUG
  • Improvement
  • Documentation
  • Feature
  • Test and CI
  • Code Refactoring

Which issue(s) this PR fixes:

issue ##25079

What this PR does / why we need it:

修改 protected database lower case db name 问题

@qodo-code-review

Copy link
Copy Markdown

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

@mergify mergify Bot added the kind/bug Something isn't working label Jun 25, 2026
@daviszhen

Copy link
Copy Markdown
Contributor Author

@mergify refresh

@mergify

mergify Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

refresh

✅ Pull request refreshed

@XuPeng-SH XuPeng-SH left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-checked the latest head. The previous blockers are fixed: protected_databases parsing no longer substitutes empty elements with the current database, and lower_case_table_names=2 is now treated consistently with the engine’s case-insensitive identifier semantics. The added unit/BVT coverage also pins those boundary cases, so I do not see a remaining correctness issue that should keep this blocked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug Something isn't working size/L Denotes a PR that changes [500,999] lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants