feat(KMP-6): move home tab icons and strings into shared resources#176
Open
js-jasinski wants to merge 6 commits into
Open
feat(KMP-6): move home tab icons and strings into shared resources#176js-jasinski wants to merge 6 commits into
js-jasinski wants to merge 6 commits into
Conversation
…ugin Introduces a `library-kmp-module` convention plugin in buildSrc so modules can target Android and iOS with Compose Multiplatform. Uses the AGP `com.android.kotlin.multiplatform.library` plugin (avoids the kotlin.android <-> kotlin.multiplatform conflict) and gates iOS targets to macOS.
Converts common-navigation to a Kotlin Multiplatform module via the library-kmp-module convention.
Converts home/ui to a Kotlin Multiplatform module. All existing code moves to the Android source set unchanged, and the shared source set is left empty, so iOS compiles with nothing in it yet. - switch home/ui to the multiplatform module convention - move all sources and resources into androidMain, with no code changes - apply the Metro, KSP and serialization plugins directly - run showkase and the navigation compiler through kspAndroid - keep the Accompanist permissions opt-in on the Android source set only - drop the unused parcelize plugin
Moves the home screen's content and its navigation bar/rail into the shared source set so the home screen's visuals run on both Android and iOS. - move HomeScreenContent and the nav bar/rail into commonMain - make it data-driven over a list of tabs (tab + icon + label) so it no longer depends on Android resources - build that tab list from Android resources in the Android HomeScreen wrapper - keep the kotlinova screen wrapper, window-size check and previews on Android - add Compose Multiplatform material3 and foundation to commonMain
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Problem
The home screen's tab icons and labels lived in the Android source set, so the shared home screen couldn't show its tabs on iOS.
Solution
Developer Notes