feat(KMP-3): introduce shared Tab model and adapt SelectedTabContent#173
Open
js-jasinski wants to merge 3 commits into
Open
feat(KMP-3): introduce shared Tab model and adapt SelectedTabContent#173js-jasinski wants to merge 3 commits into
js-jasinski wants to merge 3 commits into
Conversation
…ugin Introduces a `library-kmp-module` convention plugin in buildSrc so modules can target Android and iOS with Compose Multiplatform. Uses the AGP `com.android.kotlin.multiplatform.library` plugin (avoids the kotlin.android <-> kotlin.multiplatform conflict) and gates iOS targets to macOS.
Converts common-navigation to a Kotlin Multiplatform module via the library-kmp-module convention.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the bottom navigation's "compare the current screen key by type" logic with a simple Tab enum (WATCHES, WATCH_APPS, NOTIFICATIONS, TOOLS).
Added a Tab enum and a TabKey interface. The four top-level screen keys (watches, watch apps, notifications, tools) now declare which tab they belong to.
SelectedTabContent now holds the selected Tab instead of the raw screen key.
HomeScreen highlights and switches tabs using Tab values instead of checking screen-key types. A small helper maps each Tab back to its screen key when navigating.
Moved Tab, SelectedTabContent, and LocalSelectedTabContent into commonMain so they can be shared across platforms.