feat(KMP-1): add Compose Multiplatform and library-kmp-module convention plugin#171
Open
js-jasinski wants to merge 1 commit into
Open
feat(KMP-1): add Compose Multiplatform and library-kmp-module convention plugin#171js-jasinski wants to merge 1 commit into
js-jasinski wants to merge 1 commit into
Conversation
…ugin Introduces a `library-kmp-module` convention plugin in buildSrc so modules can target Android and iOS with Compose Multiplatform. Uses the AGP `com.android.kotlin.multiplatform.library` plugin (avoids the kotlin.android <-> kotlin.multiplatform conflict) and gates iOS targets to macOS.
js-jasinski
changed the title
js-jasinski
changed the title
matejdro
reviewed
Jul 1, 2026
| minSdk = 30 | ||
| } | ||
|
|
||
| if (isMac) { |
Owner
There was a problem hiding this comment.
iOS targets should always be created, even if opened on a non-mac machine.
Otherwise, we will get Dispatchers.IO conflicts: Kotlin/kotlinx.coroutines#4568
See coredevices/mobileapp#47, we had that same issue in the Core app
matejdro
reviewed
Jul 1, 2026
| id("org.jetbrains.kotlin.plugin.compose") | ||
| id("org.jetbrains.compose") | ||
|
|
||
| id("checks") |
Owner
There was a problem hiding this comment.
This file currently duplicates a lot of things from the all-modules-commons. Can we try reusing it instead, so android and kmp modules have a common base without duplication?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a library-kmp-module convention plugin in buildSrc so modules can target Android and iOS with Compose Multiplatform. Uses the AGP com.android.kotlin.multiplatform.library plugin (avoids the kotlin.android <-> kotlin.multiplatform conflict) and gates iOS targets to macOS.