Fix date_time.hpp error and header generator warnings#298
Merged
marzer merged 5 commits intomarzer:masterfrom Apr 17, 2026
Merged
Fix date_time.hpp error and header generator warnings#298marzer merged 5 commits intomarzer:masterfrom
marzer merged 5 commits intomarzer:masterfrom
Conversation
Removed preprocessor directives to enable noexcept features.
Contributor
Author
|
Sorry, I was trying to figure out where this goes (if it goes somewhere): It came from the header generator. The second pull request I created, I realized I forgot to run the tests so I went back and tested and got some errors and fixed it maybe, by just removing line 7 and 8 from date_and_time.hpp |
Owner
|
Ah, right. Yep, they need to go here: https://github.com/marzer/tomlplusplus/blob/master/tools%2Fgenerate_single_header.py#L206 Looks like some past contribution didn't add them, and I didn't catch it at the time. |
Contributor
Author
|
Hey I updated the header generator how do I PR it into this same PR thread? |
…T_NOEXCEPT macros Added new macros to the list of defines in generate_single_header.py.
Owner
|
Looks good, thanks! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change do?
Is it related to an exisiting bug report or feature request?
Pre-merge checklist
origin/master(if necessary)