Skip to content

Fix date_time.hpp error and header generator warnings#298

Merged
marzer merged 5 commits intomarzer:masterfrom
dwithun-dev:optional_error
Apr 17, 2026
Merged

Fix date_time.hpp error and header generator warnings#298
marzer merged 5 commits intomarzer:masterfrom
dwithun-dev:optional_error

Conversation

@dwithun-dev
Copy link
Copy Markdown
Contributor

@dwithun-dev dwithun-dev commented Apr 15, 2026

What does this change do?

Is it related to an exisiting bug report or feature request?

Pre-merge checklist

  • I've read CONTRIBUTING.md
  • I've rebased my changes against the current HEAD of origin/master (if necessary)
  • I've added new test cases to verify my change
  • I've regenerated toml.hpp (how-to)
  • I've updated any affected documentation
  • I've rebuilt and run the tests with at least one of:
    • Clang 8 or higher
    • GCC 8 or higher
    • MSVC 19.20 (Visual Studio 2019) or higher
  • I've added my name to the list of contributors in README.md

Removed preprocessor directives to enable noexcept features.
@dwithun-dev dwithun-dev reopened this Apr 15, 2026
@dwithun-dev
Copy link
Copy Markdown
Contributor Author

Sorry, I was trying to figure out where this goes (if it goes somewhere):

It came from the header generator.
Potentially missing #undefs:
#undef TOML_DISABLE_CONDITIONAL_NOEXCEPT_LAMBDA
#undef TOML_DISABLE_NOEXCEPT_NOEXCEPT

The second pull request I created, I realized I forgot to run the tests so I went back and tested and got some errors and fixed it maybe, by just removing line 7 and 8 from date_and_time.hpp

@marzer
Copy link
Copy Markdown
Owner

marzer commented Apr 15, 2026

Ah, right. Yep, they need to go here: https://github.com/marzer/tomlplusplus/blob/master/tools%2Fgenerate_single_header.py#L206

Looks like some past contribution didn't add them, and I didn't catch it at the time.

@dwithun-dev
Copy link
Copy Markdown
Contributor Author

dwithun-dev commented Apr 16, 2026

Hey I updated the header generator how do I PR it into this same PR thread?

@dwithun-dev dwithun-dev marked this pull request as draft April 16, 2026 13:07
…T_NOEXCEPT macros

Added new macros to the list of defines in generate_single_header.py.
Copy link
Copy Markdown
Contributor Author

@dwithun-dev dwithun-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@dwithun-dev dwithun-dev marked this pull request as ready for review April 16, 2026 13:41
@marzer marzer merged commit e794587 into marzer:master Apr 17, 2026
15 checks passed
@marzer
Copy link
Copy Markdown
Owner

marzer commented Apr 17, 2026

Looks good, thanks! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants