Skip to content

Move Goggles account identity into JSONL source_context#625

Merged
erskingardner merged 2 commits into
masterfrom
cursor/goggles-audit-upload-source-cleanup
Jun 26, 2026
Merged

Move Goggles account identity into JSONL source_context#625
erskingardner merged 2 commits into
masterfrom
cursor/goggles-audit-upload-source-cleanup

Conversation

@erskingardner

@erskingardner erskingardner commented Jun 26, 2026

Copy link
Copy Markdown
Member

Summary

  • Remove AuditLogUploadSource.account_label and stop sending X-Goggles-Account-Label on Goggles uploads.
  • Write richer source_context metadata at recorder open (account display label, stable device_id, and host-supplied device/platform/app version from tracker config).
  • Share tracker config on MarmotApp so recorder open and upload use the same client metadata.

Test plan

  • cargo test -p marmot-app -- audit_log
  • cargo test -p marmot-uniffi -- audit

Client follow-up

Host apps should remove source.accountLabel from setAuditLogTrackerConfig and set bearer token + deviceLabel / platform / appVersion at startup (before opening account sessions).

Made with Cursor


Open in Stage

Drop upload account_label config and X-Goggles-Account-Label header; write
device/client metadata into source_context at recorder open from tracker config.

Co-authored-by: Cursor <cursoragent@cursor.com>
@stage-review

stage-review Bot commented Jun 26, 2026

Copy link
Copy Markdown

Ready to review this PR? Stage has broken it down into 5 individual chapters for you:

Title
1 Update audit logging architecture documentation
2 Remove account_label from tracker config types
3 Centralize tracker config on MarmotApp
4 Write rich source_context at recorder open
5 Update audit logging tests
Open in Stage

Chapters generated by Stage for commit 17519fa on Jun 26, 2026 3:41pm UTC.

@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@erskingardner, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 27 minutes and 34 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 74816edd-5f36-4c8b-9eb5-fbe7e2e9e690

📥 Commits

Reviewing files that changed from the base of the PR and between a310ede and 17519fa.

📒 Files selected for processing (9)
  • crates/marmot-app/src/audit_log.rs
  • crates/marmot-app/src/config.rs
  • crates/marmot-app/src/lib.rs
  • crates/marmot-app/src/runtime/mod.rs
  • crates/marmot-app/tests/audit_logs.rs
  • crates/marmot-app/tests/relay_runtime.rs
  • crates/marmot-uniffi/src/conversions/audit.rs
  • crates/marmot-uniffi/tests/smoke.rs
  • docs/marmot-architecture/audit-logging.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cursor/goggles-audit-upload-source-cleanup

Comment @coderabbitai help to get the list of available commands.

Co-authored-by: Cursor <cursoragent@cursor.com>
@erskingardner erskingardner marked this pull request as ready for review June 26, 2026 16:06
@erskingardner erskingardner merged commit f62b645 into master Jun 26, 2026
28 of 30 checks passed
@erskingardner erskingardner deleted the cursor/goggles-audit-upload-source-cleanup branch June 26, 2026 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant