-
Notifications
You must be signed in to change notification settings - Fork 0
feat/make windows ebusy errors less fatal #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -1,18 +1,12 @@ | ||||||||||||||||||||||||||
| import { workspaceRoot } from '@nx/devkit'; | ||||||||||||||||||||||||||
| import inquirer from 'enquirer'; | ||||||||||||||||||||||||||
| import { | ||||||||||||||||||||||||||
| mkdirSync, | ||||||||||||||||||||||||||
| readdirSync, | ||||||||||||||||||||||||||
| readFileSync, | ||||||||||||||||||||||||||
| renameSync, | ||||||||||||||||||||||||||
| rmSync, | ||||||||||||||||||||||||||
| writeFileSync, | ||||||||||||||||||||||||||
| } from 'fs'; | ||||||||||||||||||||||||||
| import { readFileSync, writeFileSync } from 'fs'; | ||||||||||||||||||||||||||
| import { execSync } from 'node:child_process'; | ||||||||||||||||||||||||||
| import { mkdirSync, readdirSync, renameSync, rmSync } from 'node:fs'; | ||||||||||||||||||||||||||
|
Comment on lines
+2
to
+4
|
||||||||||||||||||||||||||
| import { readFileSync, writeFileSync } from 'fs'; | |
| import { execSync } from 'node:child_process'; | |
| import { mkdirSync, readdirSync, renameSync, rmSync } from 'node:fs'; | |
| import { execSync } from 'node:child_process'; | |
| import { | |
| mkdirSync, | |
| readFileSync, | |
| readdirSync, | |
| renameSync, | |
| rmSync, | |
| writeFileSync, | |
| } from 'node:fs'; |
Copilot
AI
Apr 3, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FileSystemAdapter.removeDir now relies on fs.rmSync retry behavior and intentionally downgrades failures to warnings. There isn’t test coverage for this behavior (e.g., verifying it doesn’t throw when rmSync fails and that a warning is emitted), and the previous integration-style test for removal behavior was removed. Adding a focused unit test (mocking rmSync) would help prevent regressions, especially on Windows EBUSY scenarios.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rimrafis added to devDependencies but doesn't appear to be used anywhere in the repo (search only finds it in package.json / lockfile). This increases install surface area unnecessarily; either remove the dependency or switch the directory-removal implementation to userimrafso the dependency is justified.