Keep the import progress popup quiet while Hot Folder polls - #814
Merged
marcinz606 merged 1 commit intoAug 12, 2026
Merged
Conversation
Hot Folder scans every 2 s, and each new frame starts a per-frame "Hashing files" then "Generating thumbnails" batch. The progress popup shows and raises itself on every batch, so a tethered capture session gets a popup over the canvas on each shutter release. Gate the popup in the main window: while Hot Folder is on, the non-abortable quick import batches stay silent — the HUD status line already reports them. Abortable batches (export, autocrop, normalization, stitch, HDR, contact sheet) show the popup as before. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Owner
|
merged, thanks for contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Hot Folder polls the current folder every 2 s. Each frame a tethering app (NX Tether etc.) or scanner drops in starts a per-frame "Hashing files" and then "Generating thumbnails" batch, and the batch progress popup
show()s andraise_()s itself on every one of them. During a tethered scanning session the "Working…" dialog pops over the canvas on every shutter release — the same "reads as wait here mid-roll" problem the Scanlight live view already works around locally inscanlight.py(_keep_scan_windows_on_top).Fix
Gate the popup at the
batch_startedconnection inMainWindow: while the Hot Folder toggle is on, the quick per-frame import batches — the only non-abortable ones — do not show the popup. The HUD status line over the canvas still reports them ("SCANNING FOR ASSETS…", "GENERATING THUMBNAILS…"), so the import is never silent.Every abortable batch (export, autocrop, normalization, stitch, HDR merge, contact sheet) shows the popup exactly as before, and with Hot Folder off nothing changes.
Also documents the behaviour in the Hot Folder bullet of
docs/USER_GUIDE.md.Testing
ruff format/ruff check: cleanty check(Makefile flags): cleanpytest tests/test_batch_progress.py tests/test_dock_panels.py tests/test_empty_state_and_header.py: 19 passedmainon the same machine (platform-specific:test_parallel_gate,test_updatersh scripts, ICC, etc.), so this change introduces none.Context: found while tethered-scanning on Windows with NX Tether dropping NEFs into a hot folder — the popup raised on every shutter release.
🤖 Generated with Claude Code