I'm sharing: Context API and Cleanup, really not ready#1
Open
langpavel wants to merge 23 commits into
Open
Conversation
Support for: - new Context API - static getDerivedStateFromProps
…Context.Consumer)
createContext() vs. React.createContext() made no difference - I just choose the latter because of personal preference
e.g. "now" and "formatters"
langpavel
changed the title
Owner
|
Hey, |
Author
|
Update of current code is wasting by time by my own experience. I tried this. |
|
@DragonRaider5 what is the status on your New Context API branch ? is is ready to use ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WARNING: You don't want merge this :-)
Please, do not take this seriously, you can checkout my current version which I'm using now.. many of features are disabled
For example I completely drop
<FormattedHTMLMessage />and other apis are not really ideal..My goal is
Translatorclass which can be used with ease outside of React……and I know that I will need
TranslatorManagersingleton on client which will be feeded automatically by Webpack generated code…Also note my rewrite of
babel-plugin-react-intl(published on npm as@langpavel/babel-plugin-react-intl)