Merged
Conversation
filiphr
requested changes
Dec 28, 2025
Member
filiphr
left a comment
filiphr
left a comment
There was a problem hiding this comment.
This is amazing @hduelme. Thanks a lot.
I've added one small comment regarding the <=> operator. I didn't know it and I had to look it up. I think adding a small comment about what that if check does would help us a lot down the line. Also there is a conflict now due to me merging that other PRs from you. Can you please fix the conflicts?
hduelme
force-pushed
the
intellij-platform-2025-3
branch
from
2d4d905 to
4eb629c
Compare
Contributor
Author
|
@filiphr comment added and merge conflict resolved by rebasing onto the master branch. We could also consider upgrading Gradle to version 9 in a follow-up PR. |
filiphr
approved these changes
Dec 28, 2025
Member
|
Thanks a lot @hduelme. I've squashed everything and merged it.
I'm OK upgrading Gradle to version 9. Feel free to do a PR with it. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added Intellij platform 2025 3 support.
In 2025.3 IntelliJ IDEA Community and Ultimate are combined into one product. See https://blog.jetbrains.com/platform/2025/11/intellij-platform-2025-3-what-plugin-developers-should-know/
Along with this change the build system was updated. See Requirements
I updated the
org.jetbrains.intellij.platformplugin incrementally.This required to update gradle to 8.14.3. For this I followed the instructions on https://docs.gradle.org/9.0.0/userguide/upgrading_version_8.html.
Task.getProject()is now deprecated https://docs.gradle.org/9.0.0/userguide/upgrading_version_8.html#task_projecttaskshould be replaced withtasks.registerhttps://docs.gradle.org/9.0.0/userguide/upgrading_version_8.html#deprecated_namersThe latest version of
org.jetbrains.intellij.platformseems to need more ram in GitHub Action, I increased the RAM to1024 MB.Last of all I increased the minimal supported version to 2024.2 (224) and increased the JVM Version to 21.