Extract and use camera serial number for sequence building #795
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caglarpir
force-pushed
the
camera-serial-sequence
branch
2 times, most recently
from
12d3703 to
bdd17d6
Compare
Summary: This change adds camera serial number extraction from EXIF/XMP metadata and uses it for sequence building. Previously, images were grouped into sequences only by directory, device make/model, and dimensions. This could incorrectly group images from different physical cameras of the same model into the same sequence. With this change, images from different camera bodies (identified by their unique serial numbers) are now correctly split into separate sequences, even if they have the same make/model. **Changes:** - Added `extract_camera_uuid()` method to `ExifReadFromXMP`, `ExifReadFromEXIF`, and `ExifToolReadVideo` classes - Extracts body serial and lens serial from various EXIF/XMP tags, creating a composite ID when both are present - Added `MAPCameraUUID` field to `VideoMetadata` type and propagated through the pipeline - Added `MAPCameraUUID` to sequence grouping criteria in `process_sequence_properties.py` - Updated JSON serialization to include the new field Test Plan: Added comprehensive unit tests covering: - EXIF body/lens serial extraction with priority ordering - XMP serial extraction from various namespace tags (exif, exifEX, aux) - Video metadata serial extraction (GoPro, Insta360, ExifIFD) - Sequence grouping by camera UUID (verifying images with different camera UUIDs are split into separate sequences) All existing tests pass.
caglarpir
force-pushed
the
camera-serial-sequence
branch
from
bdd17d6 to
55953ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change adds camera serial number extraction from EXIF/XMP metadata and uses it for sequence building. Previously, images were grouped into sequences only by directory, device make/model, and dimensions. This could incorrectly group images from different physical cameras of the same model into the same sequence.
With this change, images from different camera bodies (identified by their unique serial numbers) are now correctly split into separate sequences, even if they have the same make/model.
Changes
extract_camera_uuid()method toExifReadFromXMP,ExifReadFromEXIF, andExifToolReadVideoclassesMAPCameraUUIDfield toVideoMetadatatype and propagated through the pipelineMAPCameraUUIDto sequence grouping criteria inprocess_sequence_properties.pyTest Plan
Added comprehensive unit tests covering:
All existing tests pass.