various: publish cached closure narinfos in cache loop#127
Merged
Conversation
amaanq
force-pushed
the
cache-closure-narinfos
branch
2 times, most recently
from
558242d to
9f713ce
Compare
NotAShelf
requested changes
Jun 27, 2026
NotAShelf
left a comment
NotAShelf
left a comment
Member
There was a problem hiding this comment.
Left some comments. Some of them are just a little bit speculative but I'd like to catch things before they explode.
amaanq
force-pushed
the
cache-closure-narinfos
branch
4 times, most recently
from
efdd4ba to
c179dda
Compare
Member
|
CI is still failing and there are file conflicts |
NotAShelf
changed the title
amaanq
force-pushed
the
cache-closure-narinfos
branch
from
c179dda to
3384cd1
Compare
NotAShelf
requested changes
Jul 3, 2026
amaanq
force-pushed
the
cache-closure-narinfos
branch
from
3384cd1 to
91fc475
Compare
NotAShelf
reviewed
Jul 4, 2026
NotAShelf
left a comment
NotAShelf
left a comment
Member
There was a problem hiding this comment.
I left two more comments. Neither of them are actual blockers but I'm leaving it to you to decide whether they're severe enough to address now or if we should note those down and address in a followup in the case you don't want to block this PR further.
amaanq
force-pushed
the
cache-closure-narinfos
branch
from
91fc475 to
729a154
Compare
Cached builds that reused an existing output only published narinfos for the primary output, so clients could miss dependencies from the project cache. Publish signed narinfos for the whole closure, keep project ownership separate for shared store paths, and move recursive lookup and signing out of the scheduler loop. Co-authored-by: Amaan Qureshi <git@amaanq.com>
amaanq
force-pushed
the
cache-closure-narinfos
branch
from
729a154 to
d2c919b
Compare
NotAShelf
approved these changes
Jul 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cached builds that reused an existing output only published narinfos for the primary output, so clients could miss dependencies from the project cache.
Publish signed narinfos for the whole closure, keep project ownership separate for shared store paths, and move recursive lookup and signing out of the scheduler loop.