[Bugfix] [ECL] Dose of dawnglow blight only applied in opponent main phase - #16047
Open
TLeth wants to merge 3 commits into
Open
[Bugfix] [ECL] Dose of dawnglow blight only applied in opponent main phase#16047TLeth wants to merge 3 commits into
TLeth wants to merge 3 commits into
Conversation
…hen cast outside your and opponent main phases
…ase except your own main phase
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The condition
IsMainPhaseCondition.NOT_YOURSidentifies exactly opponent main phases, but the Dose of dawnglow's additional blight price should apply in all phases except your main phases. So the current implementation doesn't apply the cost in any combat upkeep draw ect phases.I arguably think
IsMainPhaseCondition.NOT_YOURSdoes what it says on the tin and therefor I have fixed it in the card implementation by negatingIsMainPhaseCondition.YOURS. After this there is no usages ofIsMainPhaseCondition.NOT_YOURSbut i chose to leave it in to keep PR minimal.test_BlightOutsideMainPhasefails with current implementationtest_NoBlightDuringMainPhasepasses with current implementation