Skip to content

Panel_AMOLED: do not keep a framebuffer object whose init failed #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lovyan03 merged 1 commit into from
Sep 11, 2026
Merged

Panel_AMOLED: do not keep a framebuffer object whose init failed #285

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 18 additions & 5 deletions src/lgfx/v1/panel/Panel_AMOLED.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@

#if defined (ESP_PLATFORM)

#include <new>

#include "Panel_Device.hpp"
#include "Panel_FrameBufferBase.hpp"
#include "../platforms/common.hpp"
Expand Down Expand Up @@ -88,11 +90,22 @@ namespace lgfx
{
if(_panel_fb)
return true;
_panel_fb = new Panel_AMOLED_Framebuffer(this);
_panel_fb->config(_cfg);
_panel_fb->setColorDepth(_write_depth);
_panel_fb->setRotation(getRotation());
return _panel_fb->init(false);
auto fb = new (std::nothrow) Panel_AMOLED_Framebuffer(this);
if (!fb)
return false;
fb->config(_cfg);
fb->setColorDepth(_write_depth);
fb->setRotation(getRotation());
// Keep _panel_fb null on failure: a leftover object without a
// buffer would make the next call report success and route
// display() through a framebuffer that does not exist.
if (!fb->init(false))
{
delete fb;
return false;
}
_panel_fb = fb;
return true;
}

void deinitPanelFb()
Expand Down
Loading