Fix TypeError on Python 3.14 when annotations reference TYPE_CHECKING… - #327
Open
philsong4-ai wants to merge 1 commit into
Open
Fix TypeError on Python 3.14 when annotations reference TYPE_CHECKING…#327philsong4-ai wants to merge 1 commit into
philsong4-ai wants to merge 1 commit into
Conversation
…-only names (lundberg#322) inspect.getfullargspec forces evaluation of a callable's annotations, which under PEP 649 (Python 3.14+) raises ``TypeError: unsupported callable`` for callables that reference names only available under TYPE_CHECKING (e.g. typing a SQLAlchemy AsyncSession fixture without importing it at runtime). respx only needs parameter names, so when getfullargspec fails we fall back to inspect.signature with annotation_format set to ForwardRef on 3.14+, degrading unresolved names to ForwardRef placeholders instead of raising.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…-only names (#322)
inspect.getfullargspec forces evaluation of a callable's annotations, which under PEP 649 (Python 3.14+) raises
TypeError: unsupported callablefor callables that reference names only available under TYPE_CHECKING (e.g. typing a SQLAlchemy AsyncSession fixture without importing it at runtime).respx only needs parameter names, so when getfullargspec fails we fall back to inspect.signature with annotation_format set to ForwardRef on 3.14+, degrading unresolved names to ForwardRef placeholders instead of raising.