Bump ethnum-rs and dtc dependencies - #333
Merged
Merged
Conversation
Required to include nlordell/ethnum-rs#58 which is needed for more recent Rust compilers which reject this failure. Signed-off-by: James Wainwright <james.wainwright@lowrisc.org>
Includes commit 9a1c801a1a3c102bf95c5339c9e985b26b823a21 [0] which is needed for more recent compilers which reject the `const` qualifier being dropped by default. [0]: https://gitlab.com/qemu-project/dtc/-/commit/9a1c801a1a3c102bf95c5339c9e985b26b823a21 Signed-off-by: James Wainwright <james.wainwright@lowrisc.org>
AlexJones0
approved these changes
Jul 30, 2026
Author
|
Thanks Alex, the CI failures do look like upstream changes and not build failures, so I'll merge and cut a release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both dependencies have errors which fail to compile using recent compilers. We build QEMU with host tools in OpenTitan (due to how
rules_foreign_ccworks) and the build recently started failing due to theethnum-rsRust error.When I fixed the Rust error locally, my C host compiler rejected
libdtcdue to another problem (Ubuntu 26.04). See the commit messages for details.