[otbn/tvla] Add ml-dsa tvla and fi tests - #31102
Merged
Merged
Conversation
After the new Bivium RNG, update the manner at which URND is used in the tvla and fi simulation testing (include it to work for single trace reference runs and handle reseed_done). Also add the mai as dependency in otbnsim and include wfi handling. Signed-off-by: Siemen Dhooghe <sdhooghe@google.com>
Add simulation tvla tests for mldsa sign and keygen. Signed-off-by: Siemen Dhooghe <sdhooghe@google.com>
siemen11
force-pushed
the
otbn_tvla_mldsa
branch
from
August 24, 2026 20:57
0d2d705 to
1262ad9
Compare
siemen11
changed the title
Add collision tests for instruction skip simulations for ml-dsa sign and verify. Signed-off-by: Siemen Dhooghe <sdhooghe@google.com>
siemen11
force-pushed
the
otbn_tvla_mldsa
branch
from
August 27, 2026 07:27
fed207d to
c339062
Compare
siemen11
marked this pull request as ready for review
August 27, 2026 07:30
andrea-caforio
approved these changes
Aug 27, 2026
andrea-caforio
left a comment
andrea-caforio
left a comment
Contributor
There was a problem hiding this comment.
Let's go! Thank you @siemen11.
Contributor
Author
|
Ok the fi campaign of the sign is still too slow, need to optimize that still |
Contributor
How many rejection loops are executed for your sign input? Would an input that only executes one loop work? |
Contributor
Author
Many it seems because we are making a toy version of the ml-dsa, I will use it in abridged mode :D thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add simulation tvla and fi tests for mldsa sign and keygen.