Add changes to generate and endorse certificate with ML-DSA 87 public key as well - #31055
Merged
cfrantz merged 3 commits intoSep 9, 2026
Conversation
xorptr
commented
Aug 19, 2026
xorptr
force-pushed
the
perso_ft_provisioning_add_uds_mldsa_87_certgen_and_endorse
branch
from
August 19, 2026 01:24
daa685b to
2b82dad
Compare
xorptr
marked this pull request as ready for review
August 20, 2026 07:07
xorptr
force-pushed
the
perso_ft_provisioning_add_uds_mldsa_87_certgen_and_endorse
branch
2 times, most recently
from
August 23, 2026 08:01
b2a20ac to
af95f5c
Compare
sasdf
reviewed
Aug 24, 2026
xorptr
force-pushed
the
perso_ft_provisioning_add_uds_mldsa_87_certgen_and_endorse
branch
from
September 1, 2026 19:53
af95f5c to
59b0951
Compare
xorptr
force-pushed
the
perso_ft_provisioning_add_uds_mldsa_87_certgen_and_endorse
branch
2 times, most recently
from
September 3, 2026 04:38
efea75d to
cfaca12
Compare
cfrantz
approved these changes
Sep 4, 2026
xorptr
force-pushed
the
perso_ft_provisioning_add_uds_mldsa_87_certgen_and_endorse
branch
from
September 4, 2026 09:04
cfaca12 to
c2d91e4
Compare
This commit changes the name of UDS certificate generated during provisioning with ML-DSA 44 public key to `PQ_UDS_44` so that it matches with certificate name that would be used for the certificate generated with ML-DSA 87 public key (`PQ_UDS_87`) Tested by running `//sw/host/provisioning/orchestrator/tests:e2e_multistage_emulation_dice_mldsa_cw340_test` target locally with bazel argument `--//sw/host/provisioning/cert_lib:enable_mldsa_signing_for_test`. Logs show certificate with name `PQ_UDS_44` generated and endorsed Signed-off-by: Lovepreet Singh <lpsingh@google.com>
…public key This commit adds support to generate a TBS certificate with ML-DSA 87 public key in perso firmware and endorse it in the host tool. NOTE: This certificate is NOT send back to the device. The host tool just endorses the TBS certificate and validates the endorsed certificate with DICE ML-DSA 87 CA certificate. I also changed the `static_assert` conditions to reflect new constraints after adding support for this certificate Tested by running `//sw/host/provisioning/orchestrator/tests:e2e_multistage_emulation_dice_mldsa_cw340_test` target locally with bazel argument `--//sw/host/provisioning/cert_lib:enable_mldsa_signing_for_test`. Test logs show that device generates and sends both certificate (`PQ_UDS_44` and `PQ_UDS_87`) to the host. The host tool endorses them both, but sends only `PQ_UDS_44` back to the device Signed-off-by: Lovepreet Singh <lpsingh@google.com>
…DSA 87 seed generation Currently the perso firmware code generates certificates with same Subject Key ID for certificates with ML-DSA 44 and ML-DSA 87 public key. As per [Open DICE specifications](https://github.com/google/open-dice/blob/a483025423d720898cc2f7e2ac57b7dd0c65f93b/docs/specification.md#deriving-identifiers), these IDs must be different since the public keys are different. Currently ML-DSA DICE library generates theseed independent of the ML-DSA parameters set, and uses this seed to generate the key IDs. So the key IDs are the same for ML-DSA 44 and ML-DSA 87 public keys generated by the firmware. This commit changes the logic to use different derivation constants when generating the seed for ML-DSA 44 and ML-DSA 87 keys. The new derivation constants for ML-DSA 87 are generated by reading data from `/dev/random` on my workstation Tested by running `//sw/host/provisioning/orchestrator/tests:e2e_emulation_dice_mldsa_cw340_test` target locally with bazel argument `--//sw/host/provisioning/cert_lib:enable_mldsa_signing_for_test`. Endorsed certificates in the logs show `X509v3 Subject Key Identifier: 6E:02:32:65:4F:71:1E:04:A1:06:17:B3:1F:6A:61:93:84:92:60:3E` for certificate with ML-DSA 44 public key, and `X509v3 Subject Key Identifier: AD:DA:DA:07:0A:70:0A:98:CD:0C:E7:B9:B6:3C:DC:48:7E:DF:B4:CE` for certificate with ML-DSA 87 public key Signed-off-by: Lovepreet Singh <lpsingh@google.com>
xorptr
force-pushed
the
perso_ft_provisioning_add_uds_mldsa_87_certgen_and_endorse
branch
from
September 9, 2026 05:48
c2d91e4 to
96dc66a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for endorsing DICE UDS TBS certificate with ML-DSA 87 public key
PQ_UDStoPQ_UDS_44PQ_UDS_87). Appropriate configurations are changed so that the host tool expects and endorses this certificate. NOTE that the endorsedPQ_UDS_87certificate is currently not sent back to the device.Changes on top of PR #31054